Skip to content

Conversation

@matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Mar 5, 2024

This implementation ignores any changed event triggered by the file watcher that might occur before an application restart. This will significatively reduce the number of restarts of the app in watch mode.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 5, 2024
@matthieusieben
Copy link
Contributor Author

matthieusieben commented Mar 5, 2024

I made an alternate implementation, that debounces the iterator instead of the restart function here: #51983

Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthieusieben
Copy link
Contributor Author

#51992 is the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants