test: use env variable to pass value containing user controlled value #49134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tests are run from a cwd that contains special characters in its path, those would be misinterpreted by the shell and make the test fail.
nodejs-github-bot
added
async_hooks
richardlau
reviewed
Aug 13, 2023
test/abort/test-abort-fatal-error.js
Outdated
| console.log(stdout); | ||
| console.log(stderr); | ||
| assert(false, 'this test should fail'); | ||
| exec(cmdline, { env: { NODE: process.execPath } }, common.mustCall((err, stdout, stderr) => { |
Member
There was a problem hiding this comment.
You'll need to extend env otherwise the child process will fail to run in , e.g. the shared library CI configurations.
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tests are run from a cwd that contains special characters in its path, those would be misinterpreted by the shell and make the test fail.