Skip to content

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Apr 16, 2021

#36691 accidentally reverted the
change to the minimum version of Xcode for macOS.

Refs: 4268fae#r49622017
Refs: #37872

cc @targos

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 16, 2021
richardlau referenced this pull request Apr 16, 2021
PR-URL: #36691
Fixes: #25789
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2021
nodejs#36691 accidentally reverted the
change to the minimum version of Xcode for macOS.

PR-URL: nodejs#38266
Refs: nodejs@4268fae#r49622017
Refs: nodejs#37872
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau richardlau merged commit 767643f into nodejs:master Apr 18, 2021
@richardlau
Copy link
Member Author

Landed in 767643f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants