src: fix dead code in RandomPrimeTraits #37083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
Collaborator
juanarbol
approved these changes
Jan 26, 2021
jasnell
approved these changes
Jan 26, 2021
tniessen
added
the
author ready
lpinca
approved these changes
Jan 29, 2021
Member
Author
|
Landed in 0a993e1, thanks for reviewing. |
tniessen
removed
the
author ready
tniessen
added a commit
that referenced
this pull request
Jan 29, 2021
PR-URL: #37083 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37083 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jan 13, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
params->addandparams->remhave already been allocated successfully at these points, and won't be deallocated by the calls toBN_bin2bn, so these branches are effectively dead. Instead, the return value ofBN_bin2bnshould be checked.