[12.x] http, http2: flag for overriding server timeout #27704

ofrobots · 2019-05-14T22:09:11Z

Make it possible to override the default http server timeout. Ideally
there should be no server timeout - as done on the master branch. This
is a non-breaking way to enable platform providers to override the
value.

Ref: #27558
Ref: #27556

This is a semver-minor alternative to #27558 suitable for backporting to 8.x, 10.x and 12.x.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-05-14T22:09:13Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3523

nodejs-github-bot · 2019-05-14T22:47:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23122/

doc/api/cli.md

doc/api/http.md

MylesBorins

LGTM

a couple of doc nits

doc/api/http.md

doc/api/http2.md

nodejs-github-bot · 2019-05-18T00:33:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23178/

ofrobots · 2019-05-18T03:36:31Z

@nodejs/lts this is good to squash and land. Let me know if anything else is needed from my side. Once this lands, I can prepare PRs for 10.x and 8.x as well.

BridgeAR

LGTM % comments.

doc/api/cli.md

doc/api/http.md

ofrobots · 2019-05-21T17:57:07Z

CI-lite after the doc changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3588/

nodejs-github-bot · 2019-05-21T18:08:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23261/

ofrobots · 2019-05-21T18:09:54Z

@nodejs/build: the CI lite built something other than this PR. Did I do something wrong, or is it a problem with a CI-lite?

Trott · 2019-05-22T04:15:35Z

@nodejs/build: the CI lite built something other than this PR. Did I do something wrong, or is it a problem with a CI-lite?

Looks like it built this PR to me, but I may be missing something you're seeing. What makes you say CI-Lite built the wrong thing?

ofrobots · 2019-05-22T17:27:54Z

@Trott looking at the console output I see:

10:56:46  Fetching changes from the remote Git repository
10:56:46   > git rev-parse --is-inside-work-tree # timeout=10
10:56:46   > git config remote.origin.url https://github.com/nodejs/node.git # timeout=10
10:56:46  Fetching upstream changes from https://github.com/nodejs/node.git
10:56:46   > git --version # timeout=10
10:56:46   > git fetch --tags --force --progress https://github.com/nodejs/node.git +refs/heads/*:refs/remotes/origin/* # timeout=10
10:56:51  Checking out Revision 46d8af5e618554fcac89e4b15bf06f81de36ef54 (refs/remotes/origin/master)
10:56:51  Commit message: "deps: upgrade to libuv 1.29.1"
10:56:51  [Pipeline] }

This shows a commit that landed on master whereas this PR is targeting 12.x. This suggests to me that CI lite might be hard coded to pick up the master branch rather than the PR head?

Make it possible to override the default http server timeout. Ideally there should be no server timeout - as done on the master branch. This is a non-breaking way to enable platform providers to override the value. Ref: nodejs#27558 Ref: nodejs#27556

ofrobots · 2019-05-23T20:20:23Z

Landed in 588fd0c.

Make it possible to override the default http server timeout. Ideally there should be no server timeout - as done on the master branch. This is a non-breaking way to enable platform providers to override the value. Ref: #27558 Ref: #27556 PR-URL: #27704 Refs: #27558 Refs: #27556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

refack · 2019-05-24T19:25:38Z

Thanks for the heads up.

the CI lite built something other than this PR.

This shows a commit that landed on master whereas this PR is targeting 12.x. This suggests to me that CI lite might be hard coded to pick up the master branch rather than the PR head?

That ref is just used to detect which MAJOR version of node is used (which indeed was wrong), but the tests were run against this PR's ref:
https://ci.nodejs.org/job/node-test-commit-linuxone/13487/
https://ci.nodejs.org/job/node-linter/3531/console

Ref for version detection, fixed:
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3625/console
picked 4f093e8

15:19:00   > git fetch --tags --force --progress https://github.com/nodejs/node.git refs/pull/27704/head:refs/remotes/origin/_jenkins_local_branch # timeout=10
15:19:03  Checking out Revision 4f093e879b110771b586b701ddd2e9438a9e0eb9 (refs/remotes/origin/_jenkins_local_branch)
15:19:04  Commit message: "http, http2: flag for overriding server timeout"
15:19:04  [Pipeline] }
15:19:04  [Pipeline] // stage
15:19:04  [Pipeline] stage
15:19:04  [Pipeline] { (Run tests)
15:19:04  [Pipeline] script
15:19:04  [Pipeline] {
15:19:04  [Pipeline] sh
15:19:03   > git rev-parse refs/remotes/origin/_jenkins_local_branch^{commit} # timeout=10
15:19:03   > git rev-parse refs/remotes/origin/refs/heads/_jenkins_local_branch^{commit} # timeout=10
15:19:03   > git config core.sparsecheckout # timeout=10
15:19:03   > git checkout -f 4f093e879b110771b586b701ddd2e9438a9e0eb9 # timeout=10
15:19:05  + python tools/getnodeversion.py
15:19:05  [Pipeline] echo
15:19:05  Detected node version: 12.3.2
15:19:05  [Pipeline] echo
15:19:05  NODE_MAJOR_VERSION=12

Make it possible to override the default http server timeout. Ideally there should be no server timeout - as done on the master branch. This is a non-breaking way to enable platform providers to override the value. PR-URL: nodejs#27704 Refs: nodejs#27558 Refs: nodejs#27556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Notable changes: * doc: * The JSON variant of the API documentation is no longer experimental (Rich Trott) #27842. * esm: * JSON module support is always enabled under `--experimental-modules`. The `--experimental-json-modules` flag has been removed (Myles Borins) #27752. * http,http2: * A new flag has been added for overriding the default HTTP server socket timeout (which is two minutes). Pass `--http-server-default-timeout=milliseconds` or `--http-server-default-timeout=0` to respectively change or disable the timeout. Starting with Node.js 13.0.0, the timeout will be disabled by default (Ali Ijaz Sheikh) #27704. * inspector: * Added an experimental `--heap-prof` flag to start the V8 heap profiler on startup and write the heap profile to disk before exit (Joyee Cheung) #27596. * stream: * The `readable.unshift()` method now correctly converts strings to buffers. Additionally, a new optional argument is accepted to specify the string's encoding, such as `'utf8'` or `'ascii'` (Marcos Casagrande) #27194. * v8: * The object returned by `v8.getHeapStatistics()` has two new properties: `number_of_native_contexts` and `number_of_detached_contexts` (Yuriy Vasiyarov) #27933. PR-URL: #28040

Notable changes: * doc: * The JSON variant of the API documentation is no longer experimental (Rich Trott) nodejs#27842. * esm: * JSON module support is always enabled under `--experimental-modules`. The `--experimental-json-modules` flag has been removed (Myles Borins) nodejs#27752. * http,http2: * A new flag has been added for overriding the default HTTP server socket timeout (which is two minutes). Pass `--http-server-default-timeout=milliseconds` or `--http-server-default-timeout=0` to respectively change or disable the timeout. Starting with Node.js 13.0.0, the timeout will be disabled by default (Ali Ijaz Sheikh) nodejs#27704. * inspector: * Added an experimental `--heap-prof` flag to start the V8 heap profiler on startup and write the heap profile to disk before exit (Joyee Cheung) nodejs#27596. * stream: * The `readable.unshift()` method now correctly converts strings to buffers. Additionally, a new optional argument is accepted to specify the string's encoding, such as `'utf8'` or `'ascii'` (Marcos Casagrande) nodejs#27194. * v8: * The object returned by `v8.getHeapStatistics()` has two new properties: `number_of_native_contexts` and `number_of_detached_contexts` (Yuriy Vasiyarov) nodejs#27933. PR-URL: nodejs#28040

Make it possible to override the default http server timeout. Ideally there should be no server timeout - as done on the master branch. This is a non-breaking way to enable platform providers to override the value. Backport-PR-URL: #27939 PR-URL: #27704 Refs: #27558 Refs: #27556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Prior to Node.js v13, http[2s] have a specific default timeout value which should not be confused with net.Socket default timeout. Fixes: nodejs#31378 Fixes: nodejs#27556 Refs: nodejs#27704

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels May 14, 2019

ofrobots added the semver-minor PRs that contain new features and should be released in the next minor version. label May 14, 2019

ofrobots mentioned this pull request May 14, 2019

Default http[2s] server timeout is problematic #27556

Closed

addaleax approved these changes May 14, 2019

View reviewed changes

addaleax added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. https Issues or PRs related to the https subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels May 14, 2019

mscdex reviewed May 15, 2019

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

MylesBorins reviewed May 15, 2019

View reviewed changes

doc/api/http.md Outdated Show resolved Hide resolved

MylesBorins approved these changes May 15, 2019

View reviewed changes

doc/api/http.md Outdated Show resolved Hide resolved

doc/api/http2.md Outdated Show resolved Hide resolved

doc/api/http2.md Outdated Show resolved Hide resolved

ofrobots added v10.x labels May 15, 2019

mscdex added lts-watch-v10.x and removed v10.x labels May 15, 2019

ofrobots mentioned this pull request May 17, 2019

request for temporary access to AIX machine nodejs/build#1801

Closed

BridgeAR approved these changes May 21, 2019

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

doc/api/http.md Outdated Show resolved Hide resolved

BridgeAR requested a review from Trott May 21, 2019 09:53

ofrobots force-pushed the http-server-timeout-env branch from 2a456f6 to 0759a63 Compare May 21, 2019 17:56

ofrobots force-pushed the http-server-timeout-env branch 2 times, most recently from bbd99ec to 9d8d3ca Compare May 22, 2019 17:49

ofrobots force-pushed the http-server-timeout-env branch from 9d8d3ca to 4f093e8 Compare May 22, 2019 23:48

ofrobots closed this May 23, 2019

ofrobots deleted the http-server-timeout-env branch May 23, 2019 20:20

ofrobots mentioned this pull request May 28, 2019

[10.x] http, http2: flag for overriding server timeout #27939

Closed

4 tasks

targos mentioned this pull request Jun 3, 2019

v12.4.0 release proposal #28040

Merged

BethGriggs added land-on-v10.x and removed lts-watch-v10.x labels Oct 7, 2019

aduh95 mentioned this pull request Jan 16, 2020

Hardcoded socket timeout #31378

Closed

aduh95 mentioned this pull request Jan 16, 2020

doc: add note regarding net.Socket default timeout #31379

Closed

3 tasks

Uh oh!

[12.x] http, http2: flag for overriding server timeout #27704

[12.x] http, http2: flag for overriding server timeout #27704

Uh oh!

Conversation

ofrobots commented May 14, 2019

Checklist

Uh oh!

nodejs-github-bot commented May 14, 2019

Uh oh!

nodejs-github-bot commented May 14, 2019

Uh oh!

Uh oh!

Uh oh!

MylesBorins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 18, 2019

Uh oh!

ofrobots commented May 18, 2019

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ofrobots commented May 21, 2019

Uh oh!

nodejs-github-bot commented May 21, 2019

Uh oh!

ofrobots commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented May 22, 2019

Uh oh!

ofrobots commented May 22, 2019

Uh oh!

ofrobots commented May 23, 2019

Uh oh!

refack commented May 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ofrobots commented May 21, 2019 •

edited

Loading