src: always use diagnostic file sequence number #27142
Merged
+11
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 8, 2019
richardlau
approved these changes
Apr 8, 2019
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
This makes the sequence number shared across all uses of MakeFilename(), including those that use different prefix's and/or ext's. I'm okay with it (although it feels a bit odd) but I'll point it out in case others feel differently.
Contributor
Author
Yes, I was aware of that as well. I don't think we need to overcomplicate this. If someone wants a custom filename, they can pass in a custom filename. Thanks for pointing it out though. |
jasnell
approved these changes
Apr 9, 2019
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22301/ EDIT(cjihrig): CI was green. |
BridgeAR
added
the
author ready
BridgeAR
approved these changes
Apr 9, 2019
4 tasks
This commit attaches a sequence number to all filenames that are automatically generated by DiagnosticFilename. This prevents accidental overwriting of existing files. PR-URL: nodejs#27142 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attaches a sequence number to all filenames that are automatically generated by
DiagnosticFilename. This prevents accidental overwriting of existing files.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes