test: test vm.runInNewContext() filename option #27056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'filename as a string' case was already being tested. This commit also exercises the 'filename as an option' case.
Collaborator
lpinca
approved these changes
Apr 2, 2019
cjihrig
approved these changes
Apr 2, 2019
BethGriggs
approved these changes
Apr 2, 2019
BridgeAR
approved these changes
Apr 3, 2019
BridgeAR
added
the
author ready
Collaborator
devsnek
approved these changes
Apr 3, 2019
Member
Author
|
New CI, the last one ran into infrastructure problems: https://ci.nodejs.org/job/node-test-pull-request/22168/ |
Collaborator
Member
Author
|
The failure is #26910. |
Collaborator
Contributor
|
Landed in f13733d. |
danbev
pushed a commit
that referenced
this pull request
Apr 5, 2019
The 'filename as a string' case was already being tested. This commit also exercises the 'filename as an option' case. PR-URL: #27056 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'filename as a string' case was already being tested. This commit
also exercises the 'filename as an option' case.