-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Closed
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Description
Our benchmark tasks must be modified to add a taskset command to pin the CPU the benchmark will run on. This is needed because now CPUs come with performance cores and energy efficient cores, making it harder to have reliable results otherwise.
It's also needed by nodejs/build#3657.
Lines 73 to 75 in af48641
| const child = fork(path.resolve(__dirname, job.filename), cli.optional.set, { | |
| execPath: cli.optional[job.binary], | |
| }); |
https://github.com/nodejs/node/blob/main/benchmark/run.js#L43-L46
cc @nodejs/performance
tonivj5
Metadata
Metadata
Assignees
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.