-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Closed
Labels
feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.wontfixIssues that will not be fixed.Issues that will not be fixed.
Description
Is your feature request related to a problem? Please describe.
A solution suggested for #28164 was to keep a big table of JS objects and their types, and use that to verify the type of a wrapper object before napi_unwrapping it. Currently, the only way to do this is to napi_strict_equals against every single object reference in the table, which is very slow if there are a lot of objects to keep track of.
Describe the solution you'd like
Please expose v8::Object::GetIdentityHash through N-API. This will make it possible to maintain a hash table of JS object references.
Describe alternatives you've considered
See #28164.
Metadata
Metadata
Assignees
Labels
feature requestIssues that request new features to be added to Node.js.Issues that request new features to be added to Node.js.node-apiIssues and PRs related to the Node-API.Issues and PRs related to the Node-API.wontfixIssues that will not be fixed.Issues that will not be fixed.