Investigate flaky test-worker-exit-code on Windows CI

[Trott]

https://ci.nodejs.org/job/node-test-binary-windows/23427/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/console

test-rackspace-win2008r2-x64-4

07:23:03 not ok 535 parallel/test-worker-exit-code
07:23:03   ---
07:23:03   duration_ms: 120.167
07:23:03   severity: fail
07:23:03   exitcode: 1
07:23:03   stack: |-
07:23:03     timeout
07:23:03     ok - 0 exited with 42
07:23:03     ok - 1 exited with 42
07:23:03     ok - 2 exited with 0
07:23:03     ok - 4 exited with 99
07:23:03     Error: ok
07:23:03         at Object.exitWithOneOnUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:47:9)
07:23:03         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
07:23:03         at Object.onceWrapper (events.js:285:13)
07:23:03         at MessagePort.emit (events.js:197:13)
07:23:03         at MessagePort.onmessage (internal/worker/io.js:68:8)
07:23:03     ok - 3 exited with 1
07:23:03     ok - 5 exited with 0
07:23:03     ok - 6 exited with 97
07:23:03     Error: ok
07:23:03         at Object.changeCodeInExitWithUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:93:9)
07:23:03         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
07:23:03         at Object.onceWrapper (events.js:285:13)
07:23:03         at MessagePort.emit (events.js:197:13)
07:23:03         at MessagePort.onmessage (internal/worker/io.js:68:8)
07:23:03     Error: ok
07:23:03         at Object.exitWithZeroInExitWithUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:107:9)
07:23:03         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
07:23:03         at Object.onceWrapper (events.js:285:13)
07:23:03         at MessagePort.emit (events.js:197:13)
07:23:03         at MessagePort.onmessage (internal/worker/io.js:68:8)
07:23:03     ok - 7 exited with 98
07:23:03     ok - 8 exited with 0
07:23:03   ...

[Trott]

https://ci.nodejs.org/job/node-test-binary-windows/23456/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/console

test-rackspace-win2008r2-x64-5

0:09:57 not ok 536 parallel/test-worker-exit-code
10:09:57   ---
10:09:57   duration_ms: 120.103
10:09:57   severity: fail
10:09:57   exitcode: 1
10:09:57   stack: |-
10:09:57     timeout
10:09:57     ok - 0 exited with 42
10:09:57     ok - 1 exited with 42
10:09:57     ok - 2 exited with 0
10:09:57     Error: ok
10:09:57         at Object.exitWithOneOnUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:47:9)
10:09:57         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
10:09:57         at Object.onceWrapper (events.js:285:13)
10:09:57         at MessagePort.emit (events.js:197:13)
10:09:57         at MessagePort.onmessage (internal/worker/io.js:68:8)
10:09:57     ok - 3 exited with 1
10:09:57     ok - 4 exited with 99
10:09:57     ok - 5 exited with 0
10:09:57     ok - 6 exited with 97
10:09:57     Error: ok
10:09:57         at Object.changeCodeInExitWithUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:93:9)
10:09:57         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
10:09:57         at Object.onceWrapper (events.js:285:13)
10:09:57         at MessagePort.emit (events.js:197:13)
10:09:57         at MessagePort.onmessage (internal/worker/io.js:68:8)
10:09:57     Error: ok
10:09:57         at Object.exitWithZeroInExitWithUncaught [as func] (c:\workspace\node-test-binary-windows\test\fixtures\process-exit-code-cases.js:107:9)
10:09:57         at MessagePort.parentPort.once (c:\workspace\node-test-binary-windows\test\parallel\test-worker-exit-code.js:23:54)
10:09:57         at Object.onceWrapper (events.js:285:13)
10:09:57         at MessagePort.emit (events.js:197:13)
10:09:57         at MessagePort.onmessage (internal/worker/io.js:68:8)
10:09:57     ok - 7 exited with 98
10:09:57     ok - 8 exited with 0
10:09:57   ...

[Trott]

@nodejs/platform-windows @nodejs/workers @nodejs/testing

[addaleax]

I ran a stress test on LinuxOne + 3 Windows-es: https://ci.nodejs.org/job/node-stress-single-test/2145/

Looks like this might be only flaky on win2008 (25/1000) + win2012 (10/1000) but not win2016?

This is the 4th flaky test revolving around exiting workers on Windows, besides #25702, #24005, #23873. If this is an OS-specific problem that occurs only on older versions of Windows, I’m not sure what the best strategy to figure this out is?

[gireeshpunathil]

my thinking (not proven with evidence) is that these systems present variance of latency in terms of thread life cycle, disk access and scheduling leading to race at different capacity; not necessarily anything to do with functional differences (which would have caused failures to be more consistent).

I will spend some time next week attempting to recreate one or more these.