Skip to content

Commit ff2ed3e

Browse files
committed
http: remove unused hasItems() from freelist
Remove the hasItems() method from freelist module as it is unused internally. PR-URL: #30744 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Weijia Wang <[email protected]>
1 parent dbdad4d commit ff2ed3e

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

lib/internal/freelist.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ class FreeList {
1212
this.list = [];
1313
}
1414

15-
hasItems() {
16-
return this.list.length > 0;
17-
}
18-
1915
alloc() {
2016
return this.list.length > 0 ?
2117
this.list.pop() :

test/parallel/test-freelist.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,3 @@ assert.strictEqual(flist1.free({ id: 'test5' }), false);
2828
assert.strictEqual(flist1.alloc().id, 'test3');
2929
assert.strictEqual(flist1.alloc().id, 'test2');
3030
assert.strictEqual(flist1.alloc().id, 'test1');
31-
32-
// Check list has elements
33-
const flist2 = new FreeList('flist2', 2, Object);
34-
assert.strictEqual(flist2.hasItems(), false);
35-
36-
flist2.free({ id: 'test1' });
37-
assert.strictEqual(flist2.hasItems(), true);
38-
39-
flist2.alloc();
40-
assert.strictEqual(flist2.hasItems(), false);

0 commit comments

Comments
 (0)