Skip to content

Commit feed446

Browse files
fixup! src: support configurable snapshot
Co-authored-by: Anna Henningsen <[email protected]>
1 parent c146c18 commit feed446

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/node.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ enum Flags : uint64_t {
663663
enum class SnapshotFlags : uint32_t {
664664
kDefault = 0,
665665
// Whether code cache should be generated as part of the snapshot.
666-
// Code cache reduce the time spent on compiling functions included
666+
// Code cache reduces the time spent on compiling functions included
667667
// in the snapshot at the expense of a bigger snapshot size and
668668
// potentially breaking portability of the snapshot.
669669
kWithoutCodeCache = 1 << 0,
@@ -683,7 +683,7 @@ struct SnapshotConfig {
683683
// LoadEnvironment() to run a script matching this path. In that case the
684684
// snapshot is generated as a custom snapshot and the event loop is run, so
685685
// the snapshot builder can execute asynchronous operations as long as they
686-
// are run to completion when the snasphot is taken.
686+
// are run to completion when the snapshot is taken.
687687
std::optional<std::string> builder_script_path;
688688
};
689689

test/embedding/embedtest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
9494
snapshot_config = node::SnapshotConfig{};
9595
}
9696
snapshot_config.value().flags = static_cast<node::SnapshotFlags>(
97-
static_cast<uint32_t>(snapshot_config.value().flags) &
97+
static_cast<uint32_t>(snapshot_config.value().flags) |
9898
static_cast<uint32_t>(node::SnapshotFlags::kWithoutCodeCache));
9999
} else if (arg == "--embedder-snapshot-blob") {
100100
assert(i + 1 < args.size());

0 commit comments

Comments
 (0)