diagnostics_channel: Avoid wrapping with no subscribers

Stephen Belanger · Stephen Belanger · commit fc2226630777 · 2022-11-09T12:21:31.000-08:00
diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -178,6 +178,7 @@ class TracingChannel {
   }
 
   traceSync(fn, ctx = {}, thisArg, ...args) {
+    if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
     const { start, end, error } = this.channels;
     start.publish(ctx);
     try {
@@ -194,6 +195,7 @@ class TracingChannel {
   }
 
   tracePromise(fn, ctx = {}, thisArg, ...args) {
+    if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
     const { asyncEnd, start, end, error } = this.channels;
     start.publish(ctx);
 
@@ -223,6 +225,7 @@ class TracingChannel {
   }
 
   traceCallback(fn, position = 0, ctx = {}, thisArg, ...args) {
+    if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);
     const { start, end, asyncEnd, error } = this.channels;
     start.publish(ctx);
 

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,7 @@ class TracingChannel {`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`traceSync(fn, ctx = {}, thisArg, ...args) {`
	`181`	`+ if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);`
`181`	`182`	`const { start, end, error } = this.channels;`
`182`	`183`	`start.publish(ctx);`
`183`	`184`	`try {`
`@@ -194,6 +195,7 @@ class TracingChannel {`
`194`	`195`	`}`
`195`	`196`
`196`	`197`	`tracePromise(fn, ctx = {}, thisArg, ...args) {`
	`198`	`+ if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);`
`197`	`199`	`const { asyncEnd, start, end, error } = this.channels;`
`198`	`200`	`start.publish(ctx);`
`199`	`201`
`@@ -223,6 +225,7 @@ class TracingChannel {`
`223`	`225`	`}`
`224`	`226`
`225`	`227`	`traceCallback(fn, position = 0, ctx = {}, thisArg, ...args) {`
	`228`	`+ if (!this.hasSubscribers) return ReflectApply(fn, thisArg, args);`
`226`	`229`	`const { start, end, asyncEnd, error } = this.channels;`
`227`	`230`	`start.publish(ctx);`
`228`	`231`