lib,buffer: replace new Buffer(num) with Buffer.unsafe(num)

Author: jasnell

lib/_debugger.js

@@ -108,7 +108,7 @@ Protocol.prototype.execute = function(d) {
       var resRawByteLength = Buffer.byteLength(res.raw, 'utf8');
 
       if (resRawByteLength - this.bodyStartByteIndex >= this.contentLength) {
-        var buf = new Buffer(resRawByteLength);
+        var buf = Buffer.unsafe(resRawByteLength);
         buf.write(res.raw, 0, resRawByteLength, 'utf8');
         res.body =
             buf.slice(this.bodyStartByteIndex,

lib/_stream_readable.js

@@ -858,7 +858,7 @@ function fromList(n, state) {
       if (stringMode)
         ret = '';
       else
-        ret = new Buffer(n);
+        ret = Buffer.unsafe(n);
 
       var c = 0;
       for (var i = 0, l = list.length; i < l && c < n; i++) {

lib/_tls_legacy.js

@@ -23,7 +23,7 @@ function SlabBuffer() {
 
 SlabBuffer.prototype.create = function create() {
   this.isFull = false;
-  this.pool = new Buffer(tls.SLAB_BUFFER_SIZE);
+  this.pool = Buffer.unsafe(tls.SLAB_BUFFER_SIZE);
   this.offset = 0;
   this.remaining = this.pool.length;
 };

lib/fs.js

@@ -285,7 +285,7 @@ ReadFileContext.prototype.read = function() {
   var length;
 
   if (this.size === 0) {
-    buffer = this.buffer = new SlowBuffer(kReadFileBufferLength);
+    buffer = this.buffer = SlowBuffer.unsafe(kReadFileBufferLength);
     offset = 0;
     length = kReadFileBufferLength;
   } else {
@@ -353,7 +353,7 @@ function readFileAfterStat(err, st) {
     return context.close(err);
   }
 
-  context.buffer = new SlowBuffer(size);
+  context.buffer = SlowBuffer.unsafe(size);
   context.read();
 }
 
@@ -450,7 +450,7 @@ fs.readFileSync = function(path, options) {
   } else {
     threw = true;
     try {
-      buffer = new Buffer(size);
+      buffer = Buffer.unsafe(size);
       threw = false;
     } finally {
       if (threw && !isUserFd) fs.closeSync(fd);
@@ -468,7 +468,7 @@ fs.readFileSync = function(path, options) {
       } else {
         // the kernel lies about many files.
         // Go ahead and try to read some bytes.
-        buffer = new Buffer(8192);
+        buffer = Buffer.unsafe(8192);
         bytesRead = fs.readSync(fd, buffer, 0, 8192);
         if (bytesRead) {
           buffers.push(buffer.slice(0, bytesRead));
@@ -594,7 +594,7 @@ fs.read = function(fd, buffer, offset, length, position, callback) {
 
     position = arguments[2];
     length = arguments[1];
-    buffer = new Buffer(length);
+    buffer = Buffer.unsafe(length);
     offset = 0;
 
     callback = function(err, bytesRead) {
@@ -649,7 +649,7 @@ fs.readSync = function(fd, buffer, offset, length, position) {
 
     position = arguments[2];
     length = arguments[1];
-    buffer = new Buffer(length);
+    buffer = Buffer.unsafe(length);
 
     offset = 0;
   }
@@ -1696,7 +1696,7 @@ fs.realpath = function realpath(p, cache, cb) {
 var pool;
 
 function allocNewPool(poolSize) {
-  pool = new Buffer(poolSize);
+  pool = Buffer.unsafe(poolSize);
   pool.used = 0;
 }
 

lib/internal/v8_prof_polyfill.js

@@ -60,7 +60,7 @@ try {
   process.exit(1);
 }
 const fd = fs.openSync(logFile, 'r');
-const buf = new Buffer(4096);
+const buf = Buffer.unsafe(4096);
 const dec = new (require('string_decoder').StringDecoder)('utf-8');
 var line = '';
 versionCheck();

lib/string_decoder.js

@@ -44,7 +44,7 @@ const StringDecoder = exports.StringDecoder = function(encoding) {
 
   // Enough space to store all bytes of a single character. UTF-8 needs 4
   // bytes, but CESU-8 may require up to 6 (3 bytes per surrogate).
-  this.charBuffer = new Buffer(6);
+  this.charBuffer = Buffer.unsafe(6);
   // Number of bytes received for the current incomplete multi-byte character.
   this.charReceived = 0;
   // Number of bytes expected for the current incomplete multi-byte character.

lib/tls.js

@@ -33,7 +33,7 @@ exports.getCiphers = function() {
 // Convert protocols array into valid OpenSSL protocols list
 // ("\x06spdy/2\x08http/1.1\x08http/1.0")
 function convertProtocols(protocols) {
-  var buff = new Buffer(protocols.reduce(function(p, c) {
+  var buff = Buffer.unsafe(protocols.reduce(function(p, c) {
     return p + 1 + Buffer.byteLength(c);
   }, 0));
 

lib/zlib.js

@@ -378,7 +378,7 @@ function Zlib(opts, mode) {
                     strategy,
                     opts.dictionary);
 
-  this._buffer = new Buffer(this._chunkSize);
+  this._buffer = Buffer.unsafe(this._chunkSize);
   this._offset = 0;
   this._closed = false;
   this._level = level;
@@ -426,7 +426,7 @@ Zlib.prototype.reset = function() {
 // This is the _flush function called by the transform class,
 // internally, when the last chunk has been written.
 Zlib.prototype._flush = function(callback) {
-  this._transform(new Buffer(0), '', callback);
+  this._transform(Buffer.unsafe(0), '', callback);
 };
 
 Zlib.prototype.flush = function(kind, callback) {
@@ -449,7 +449,7 @@ Zlib.prototype.flush = function(kind, callback) {
     }
   } else {
     this._flushFlag = kind;
-    this.write(new Buffer(0), '', callback);
+    this.write(Buffer.unsafe(0), '', callback);
   }
 };
 
@@ -580,7 +580,7 @@ Zlib.prototype._processChunk = function(chunk, flushFlag, cb) {
     if (availOutAfter === 0 || self._offset >= self._chunkSize) {
       availOutBefore = self._chunkSize;
       self._offset = 0;
-      self._buffer = new Buffer(self._chunkSize);
+      self._buffer = Buffer.unsafe(self._chunkSize);
     }
 
     if (availOutAfter === 0) {

test/disabled/test-dgram-send-error.js

@@ -13,7 +13,7 @@ var assert = require('assert'),
     common = require('../common'),
     dgram = require('dgram');
 
-var buf = new Buffer(1024);
+var buf = Buffer.unsafe(1024);
 buf.fill(42);
 
 var packetsReceived = 0,

test/disabled/test-fs-largefile.js

@@ -12,7 +12,7 @@ fs.truncateSync(fd, offset);
 assert.equal(fs.statSync(filepath).size, offset);
 var writeBuf = new Buffer(message);
 fs.writeSync(fd, writeBuf, 0, writeBuf.length, offset);
-var readBuf = new Buffer(writeBuf.length);
+var readBuf = Buffer.unsafe(writeBuf.length);
 fs.readSync(fd, readBuf, 0, readBuf.length, offset);
 assert.equal(readBuf.toString(), message);
 fs.readSync(fd, readBuf, 0, 1, 0);
@@ -32,4 +32,3 @@ fs.close(fd);
 process.on('exit', function() {
   fs.unlinkSync(filepath);
 });
-