events: remove return value on addEventListener

The `addEventListener()` should not return a value.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #37696
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: jasnell

lib/internal/event_target.js

@@ -329,7 +329,7 @@ class EventTarget {
 
     if (signal) {
       if (signal.aborted) {
-        return false;
+        return;
       }
       // TODO(benjamingr) make this weak somehow? ideally the signal would
       // not prevent the event target from GC.

test/parallel/test-eventtarget-whatwg-signal.js

@@ -25,7 +25,11 @@ const {
   controller.abort();
   et.dispatchEvent(new Event('test'));
   strictEqual(count, 2, 'Aborting on the controller removes the listener');
-  et.addEventListener('test', handler, { signal: controller.signal });
+  // See: https://github.com/nodejs/node/pull/37696 , adding an event listener
+  // should always return undefined.
+  strictEqual(
+    et.addEventListener('test', handler, { signal: controller.signal }),
+    undefined);
   et.dispatchEvent(new Event('test'));
   strictEqual(count, 2, 'Passing an aborted signal never adds the handler');
 }