Skip to content

Commit db5a879

Browse files
committed
Merge branch 'main' into process/get-sourcemaps-enabled
2 parents 47842aa + 9cc7327 commit db5a879

File tree

806 files changed

+8538
-2307
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

806 files changed

+8538
-2307
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test/fixtures
55
test/message/esm_display_syntax_error.mjs
66
tools/icu
77
tools/lint-md/lint-md.mjs
8+
tools/github_reporter
89
benchmark/tmp
910
benchmark/fixtures
1011
doc/**/*.js

.github/workflows/build-tarball.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,4 @@ jobs:
9494
- name: Test
9595
run: |
9696
cd $TAR_DIR
97-
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
97+
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9"

.github/workflows/coverage-linux-without-intl.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
5454
# The cause is most likely coverage's use of the inspector.
5555
- name: Test
56-
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
56+
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
5757
- name: Report JS
5858
run: npx c8 report --check-coverage
5959
env:

.github/workflows/coverage-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
5454
# The cause is most likely coverage's use of the inspector.
5555
- name: Test
56-
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9" || exit 0
56+
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
5757
- name: Report JS
5858
run: npx c8 report --check-coverage
5959
env:

.github/workflows/doc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ jobs:
4040
name: docs
4141
path: out/doc
4242
- name: Test
43-
run: NODE=$(command -v node) make test-doc-ci TEST_CI_ARGS="-p actions --measure-flakiness 9"
43+
run: NODE=$(command -v node) make test-doc-ci TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"

.github/workflows/test-asan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@ jobs:
5959
- name: Build
6060
run: make build-ci -j2 V=1
6161
- name: Test
62-
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions -t 300 --measure-flakiness 9"
62+
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' -t 300 --measure-flakiness 9"

.github/workflows/test-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ jobs:
4646
- name: Build
4747
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
4848
- name: Test
49-
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
49+
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"

.github/workflows/test-macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,4 @@ jobs:
6060
- name: Build
6161
run: make build-ci -j$(getconf _NPROCESSORS_ONLN) V=1 CONFIG_FLAGS="--error-on-warn"
6262
- name: Test
63-
run: make run-ci -j$(getconf _NPROCESSORS_ONLN) V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
63+
run: make run-ci -j$(getconf _NPROCESSORS_ONLN) V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"

.github/workflows/tools.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,14 @@ jobs:
140140
cat temp-output
141141
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
142142
rm temp-output
143+
- id: github_reporter
144+
subsystem: tools
145+
label: tools
146+
run: |
147+
./tools/dep_updaters/update-github-reporter.sh > temp-output
148+
cat temp-output
149+
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
150+
rm temp-output
143151
- id: googletest
144152
subsystem: deps
145153
label: dependencies, test

deps/googletest/include/gtest/gtest-message.h

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,13 @@
5656

5757
#include "gtest/internal/gtest-port.h"
5858

59+
#ifdef GTEST_HAS_ABSL
60+
#include <type_traits>
61+
62+
#include "absl/strings/internal/has_absl_stringify.h"
63+
#include "absl/strings/str_cat.h"
64+
#endif // GTEST_HAS_ABSL
65+
5966
GTEST_DISABLE_MSC_WARNINGS_PUSH_(4251 \
6067
/* class A needs to have dll-interface to be used by clients of class B */)
6168

@@ -111,8 +118,17 @@ class GTEST_API_ Message {
111118
*ss_ << str;
112119
}
113120

114-
// Streams a non-pointer value to this object.
115-
template <typename T>
121+
// Streams a non-pointer value to this object. If building a version of
122+
// GoogleTest with ABSL, this overload is only enabled if the value does not
123+
// have an AbslStringify definition.
124+
template <typename T
125+
#ifdef GTEST_HAS_ABSL
126+
,
127+
typename std::enable_if<
128+
!absl::strings_internal::HasAbslStringify<T>::value, // NOLINT
129+
int>::type = 0
130+
#endif // GTEST_HAS_ABSL
131+
>
116132
inline Message& operator<<(const T& val) {
117133
// Some libraries overload << for STL containers. These
118134
// overloads are defined in the global namespace instead of ::std.
@@ -133,6 +149,22 @@ class GTEST_API_ Message {
133149
return *this;
134150
}
135151

152+
#ifdef GTEST_HAS_ABSL
153+
// Streams a non-pointer value with an AbslStringify definition to this
154+
// object.
155+
template <typename T,
156+
typename std::enable_if<
157+
absl::strings_internal::HasAbslStringify<T>::value, // NOLINT
158+
int>::type = 0>
159+
inline Message& operator<<(const T& val) {
160+
// ::operator<< is needed here for a similar reason as with the non-Abseil
161+
// version above
162+
using ::operator<<;
163+
*ss_ << absl::StrCat(val);
164+
return *this;
165+
}
166+
#endif // GTEST_HAS_ABSL
167+
136168
// Streams a pointer value to this object.
137169
//
138170
// This function is an overload of the previous one. When you

0 commit comments

Comments
 (0)