Skip to content

Commit c679e6f

Browse files
committed
test: remove timers from test-tls-socket-close
Fixes: #49902
1 parent 6a2d6df commit c679e6f

File tree

1 file changed

+18
-13
lines changed

1 file changed

+18
-13
lines changed

test/parallel/test-tls-socket-close.js

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ const cert = fixtures.readKey('agent2-cert.pem');
1515
let serverTlsSocket;
1616
const tlsServer = tls.createServer({ cert, key }, (socket) => {
1717
serverTlsSocket = socket;
18+
socket.on('data', (chunk) => {
19+
assert.strictEqual(chunk[0], 46);
20+
socket.write('.');
21+
});
1822
socket.on('close', dec);
1923
});
2024

@@ -45,24 +49,25 @@ function connectClient(server) {
4549
rejectUnauthorized: false
4650
});
4751

48-
clientTlsSocket.write('foo', 'utf8', common.mustCall(() => {
52+
clientTlsSocket.write('.', 'utf8', common.mustCall(() => {
4953
assert(netSocket);
50-
netSocket.setTimeout(common.platformTimeout(10), common.mustCall(() => {
51-
assert(serverTlsSocket);
54+
}));
55+
56+
clientTlsSocket.on('data', (chunk) => {
57+
assert.strictEqual(chunk[0], 46);
5258

53-
netSocket.destroy();
54-
assert.strictEqual(netSocket.destroyed, true);
59+
netSocket.destroy();
60+
assert.strictEqual(netSocket.destroyed, true);
5561

62+
setImmediate(() => {
63+
// Close callbacks are executed after `setImmediate()` callbacks.
64+
assert.strictEqual(netSocketCloseEmitted, false);
65+
assert.strictEqual(serverTlsSocket.destroyed, false);
5666
setImmediate(() => {
57-
// Close callbacks are executed after `setImmediate()` callbacks.
58-
assert.strictEqual(netSocketCloseEmitted, false);
59-
assert.strictEqual(serverTlsSocket.destroyed, false);
60-
setImmediate(() => {
61-
assert.strictEqual(netSocketCloseEmitted, true);
62-
});
67+
assert.strictEqual(netSocketCloseEmitted, true);
6368
});
64-
}));
65-
}));
69+
});
70+
});
6671

6772
clientTlsSocket.on('close', dec);
6873
}

0 commit comments

Comments
 (0)