inspector: fix session.disconnect crash

Author: theanarkh

src/inspector_js_api.cc

@@ -69,6 +69,7 @@ class JSBindingsConnection : public AsyncWrap {
                               JSBindingsConnection* connection)
                               : env_(env),
                                 connection_(connection) {
+      connection_->Detach();
     }
 
     void SendMessageToFrontend(const v8_inspector::StringView& message)
@@ -125,7 +126,6 @@ class JSBindingsConnection : public AsyncWrap {
 
   void Disconnect() {
     session_.reset();
-    delete this;
   }
 
   static void Disconnect(const FunctionCallbackInfo<Value>& info) {

test/parallel/test-inspector-connect-to-main-thread.js

@@ -0,0 +1,19 @@
+'use strict';
+const common = require('../common');
+const { Session } = require('inspector');
+const { Worker, isMainThread, workerData } = require('worker_threads');
+
+common.skipIfInspectorDisabled();
+
+if (!workerData) {
+  common.skipIfWorker();
+}
+
+if (isMainThread) {
+  new Worker(__filename, { workerData: {} });
+} else {
+  const session = new Session();
+  session.connectToMainThread();
+  // Do not crash
+  session.disconnect();
+}