lib: enable dot-notation eslint rule

PR-URL: #18007
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Jon Moss <[email protected]>

Author: apapirovski

lib/.eslintrc.yaml

@@ -1,4 +1,6 @@
 rules:
+  dot-notation: error
+
   # Custom rules in tools/eslint-rules
   require-buffer: error
   buffer-constructor: error

lib/inspector.js

@@ -68,7 +68,7 @@ class Session extends EventEmitter {
     const id = this[nextIdSymbol]++;
     const message = { id, method };
     if (params) {
-      message['params'] = params;
+      message.params = params;
     }
     if (callback) {
       this[messageCallbacksSymbol].set(id, callback);

lib/internal/util.js

@@ -6,8 +6,8 @@ const { signals } = process.binding('constants').os;
 
 const { createPromise, promiseResolve, promiseReject } = binding;
 
-const kArrowMessagePrivateSymbolIndex = binding['arrow_message_private_symbol'];
-const kDecoratedPrivateSymbolIndex = binding['decorated_private_symbol'];
+const kArrowMessagePrivateSymbolIndex = binding.arrow_message_private_symbol;
+const kDecoratedPrivateSymbolIndex = binding.decorated_private_symbol;
 const noCrypto = !process.versions.openssl;
 
 const experimentalWarnings = new Set();

lib/module.js

@@ -729,7 +729,7 @@ Module._initPaths = function() {
     paths.unshift(path.resolve(homeDir, '.node_modules'));
   }
 
-  var nodePath = process.env['NODE_PATH'];
+  var nodePath = process.env.NODE_PATH;
   if (nodePath) {
     paths = nodePath.split(path.delimiter).filter(function(path) {
       return !!path;