File tree Expand file tree Collapse file tree 1 file changed +15
-1
lines changed Expand file tree Collapse file tree 1 file changed +15
-1
lines changed Original file line number Diff line number Diff line change @@ -468,7 +468,19 @@ failed build if you start again!
468468Jenkins collects the artifacts from the builds, allowing you to download and
469469install the new build. Make sure that the build appears correct. Check the
470470version numbers, and perform some basic checks to confirm that all is well with
471- the build before moving forward.
471+ the build before moving forward. Use the following list as a baseline:
472+
473+ * ` process.version ` is as expected
474+ * ` process.release ` is as expected
475+ * ` process.versions ` is as expected (for example, ` openssl ` or ` llhttp ` version
476+ must be in the expected updated version)
477+ * npm version (check it matches what we expect)
478+ * Run the test suite against the built binaries (optional)
479+ ``` console
480+ ./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
481+ ```
482+ <sup >There may be test issues if the branch used to test does not match the Node.js binary.</sup >
483+
472484
473485### 11. Tag and sign the release commit
474486
@@ -510,6 +522,8 @@ include the release code name.
510522The tag ** must** be signed using the GPG key that's listed for you on the
511523project README.
512524
525+ ** Note** : Don't push the tag to remote at this point.
526+
513527### 12. Set up for the next release
514528
515529On release proposal branch, edit ` src/node_version.h ` again and:
You can’t perform that action at this time.
0 commit comments