test: ensure delay in recursive fs watch tests

The recursive fs watch tests that mutate the watched folder
immediately after fs.watch() returns are all flaking in the
CI while the others that mutate the folder with a bit of delay
aren't flaking. So this patch adds a bit of delay for the rest
of the tests to deflake them.

PR-URL: #51842
Refs: nodejs/reliability#790
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Author: joyeecheung

test/parallel/test-fs-watch-recursive-add-file-to-existing-subfolder.js

@@ -48,7 +48,10 @@ watcher.on('change', function(event, filename) {
   }
 });
 
-fs.writeFileSync(childrenAbsolutePath, 'world');
+// Do the write with a delay to ensure that the OS is ready to notify us.
+setTimeout(() => {
+  fs.writeFileSync(childrenAbsolutePath, 'world');
+}, common.platformTimeout(200));
 
 process.once('exit', function() {
   assert(watcherClosed, 'watcher Object was not closed');

test/parallel/test-fs-watch-recursive-add-file-to-new-folder.js

@@ -44,8 +44,11 @@ watcher.on('change', function(event, filename) {
   }
 });
 
-fs.mkdirSync(filePath);
-fs.writeFileSync(childrenAbsolutePath, 'world');
+// Do the write with a delay to ensure that the OS is ready to notify us.
+setTimeout(() => {
+  fs.mkdirSync(filePath);
+  fs.writeFileSync(childrenAbsolutePath, 'world');
+}, common.platformTimeout(200));
 
 process.once('exit', function() {
   assert(watcherClosed, 'watcher Object was not closed');

test/parallel/test-fs-watch-recursive-add-file.js

@@ -39,7 +39,10 @@ watcher.on('change', function(event, filename) {
   }
 });
 
-fs.writeFileSync(testFile, 'world');
+// Do the write with a delay to ensure that the OS is ready to notify us.
+setTimeout(() => {
+  fs.writeFileSync(testFile, 'world');
+}, common.platformTimeout(200));
 
 process.once('exit', function() {
   assert(watcherClosed, 'watcher Object was not closed');

test/parallel/test-fs-watch-recursive-assert-leaks.js

@@ -42,4 +42,9 @@ watcher.on('change', common.mustCallAtLeast(async (event, filename) => {
 process.on('exit', function() {
   assert(watcherClosed, 'watcher Object was not closed');
 });
-fs.writeFileSync(filePath, 'content');
+
+// Do the write with a delay to ensure that the OS is ready to notify us.
+(async () => {
+  await setTimeout(200);
+  fs.writeFileSync(filePath, 'content');
+})().then(common.mustCall());

test/parallel/test-fs-watch-recursive-sync-write.js

@@ -32,4 +32,7 @@ const watcher = watch(tmpDir, { recursive: true }, common.mustCall((eventType, _
   assert.strictEqual(join(tmpDir, _filename), filename);
 }));
 
-writeFileSync(filename, 'foobar2');
+// Do the write with a delay to ensure that the OS is ready to notify us.
+setTimeout(() => {
+  writeFileSync(filename, 'foobar2');
+}, common.platformTimeout(200));

test/parallel/test-fs-watch-recursive-update-file.js

@@ -39,4 +39,7 @@ watcher.on('change', common.mustCallAtLeast(function(event, filename) {
   }
 }));
 
-fs.writeFileSync(testFile, 'hello');
+// Do the write with a delay to ensure that the OS is ready to notify us.
+setTimeout(() => {
+  fs.writeFileSync(testFile, 'hello');
+}, common.platformTimeout(200));