Skip to content

Commit 99797cc

Browse files
bnoordhuisaddaleax
authored andcommitted
build: make 'floating patch' message informational
Downgrade the 'Using floating patch' message that is emitted when a local patch is applied to the bundled ICU from a warning to a notice. There isn't anything the user can or should do so warning isn't appropriate. Instead of angry yellow use soothing green. Fixes: #26346 PR-URL: #26349 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent f65b4af commit 99797cc

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

configure.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,10 @@ def warn(msg):
585585
# track if warnings occurred
586586
warn.warned = False
587587

588+
def info(msg):
589+
prefix = '\033[1m\033[32mINFO\033[0m' if os.isatty(1) else 'INFO'
590+
print('%s: %s' % (prefix, msg))
591+
588592
def print_verbose(x):
589593
if not options.verbose:
590594
return
@@ -1232,7 +1236,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
12321236
patchfile = '%s/%s/%s' % (dir_base, patch_dir, file)
12331237
if os.path.isfile(patchfile):
12341238
srcfile = '%s/%s' % (patch_dir, file)
1235-
warn('Using floating patch "%s" from "%s"' % (patchfile, dir_base))
1239+
info('Using floating patch "%s" from "%s"' % (patchfile, dir_base))
12361240
list.append(srcfile)
12371241
break
12381242
return list

0 commit comments

Comments
 (0)