Skip to content

Commit 8c13d11

Browse files
committed
src: allow embedder control of code generation policy
1 parent 8ba54e5 commit 8c13d11

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/api/environment.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,10 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
265265
auto* allow_wasm_codegen_cb = s.allow_wasm_code_generation_callback ?
266266
s.allow_wasm_code_generation_callback : AllowWasmCodeGenerationCallback;
267267
isolate->SetAllowWasmCodeGenerationCallback(allow_wasm_codegen_cb);
268-
isolate->SetModifyCodeGenerationFromStringsCallback(
269-
ModifyCodeGenerationFromStrings);
268+
269+
auto* modify_code_generation_from_strings_callback = s.modify_code_generation_from_strings_callback ?
270+
s.modify_code_generation_from_strings_callback : ModifyCodeGenerationFromStrings;
271+
isolate->SetModifyCodeGenerationFromStringsCallback(modify_code_generation_from_strings_callback);
270272

271273
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
272274
if (per_process::cli_options->get_per_isolate_options()

src/node.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,8 @@ struct IsolateSettings {
471471
v8::PromiseRejectCallback promise_reject_callback = nullptr;
472472
v8::AllowWasmCodeGenerationCallback
473473
allow_wasm_code_generation_callback = nullptr;
474+
v8::ModifyCodeGenerationFromStringsCallback2
475+
modify_code_generation_from_strings_callback = nullptr;
474476
};
475477

476478
// Overriding IsolateSettings may produce unexpected behavior

0 commit comments

Comments
 (0)