build: fix --error-on-warn for macOS

XCode builds on macOS do not appear to inherit the `cflags` setting.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #33357
Refs: #32685
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>

Author: richardlau

node.gyp

@@ -378,6 +378,9 @@
       'conditions': [
         [ 'error_on_warn=="true"', {
           'cflags': ['-Werror'],
+          'xcode_settings': {
+            'WARNING_CFLAGS': [ '-Werror' ],
+          },
         }],
         [ 'node_intermediate_lib_type=="static_library" and '
             'node_shared=="true" and OS=="aix"', {
@@ -757,6 +760,9 @@
       'conditions': [
         [ 'error_on_warn=="true"', {
           'cflags': ['-Werror'],
+          'xcode_settings': {
+            'WARNING_CFLAGS': [ '-Werror' ],
+          },
         }],
         [ 'node_builtin_modules_path!=""', {
           'defines': [ 'NODE_BUILTIN_MODULES_PATH="<(node_builtin_modules_path)"' ]