tools: enforce use of trailing commas in tools/

PR-URL: #45889
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

Author: aduh95

.eslintrc.js

@@ -68,7 +68,7 @@ module.exports = {
       files: ['**/*.md/*.cjs', '**/*.md/*.js'],
       parserOptions: {
         sourceType: 'script',
-        ecmaFeatures: { impliedStrict: true }
+        ecmaFeatures: { impliedStrict: true },
       },
       rules: { strict: 'off' },
     },
@@ -103,11 +103,11 @@ module.exports = {
         },
         {
           name: 'Buffer',
-          message: 'Import Buffer instead of using the global'
+          message: 'Import Buffer instead of using the global',
         },
         {
           name: 'process',
-          message: 'Import process instead of using the global'
+          message: 'Import process instead of using the global',
         },
       ] },
     },
@@ -134,13 +134,7 @@ module.exports = {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', {
-      arrays: 'always-multiline',
-      exports: 'only-multiline',
-      functions: 'only-multiline',
-      imports: 'only-multiline',
-      objects: 'only-multiline',
-    }],
+    'comma-dangle': ['error', 'always-multiline'],
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',

benchmark/.eslintrc.yaml

@@ -5,4 +5,11 @@ env:
   es6: true
 
 rules:
+  comma-dangle: [error, {
+    arrays: always-multiline,
+    exports: only-multiline,
+    functions: only-multiline,
+    imports: only-multiline,
+    objects: only-multiline,
+  }]
   prefer-arrow-callback: error

doc/.eslintrc.yaml

@@ -15,4 +15,3 @@ rules:
 
   # Stylistic Issues
   no-multiple-empty-lines: [error, {max: 1, maxEOF: 0, maxBOF: 0}]
-  comma-dangle: [error, always-multiline]

lib/.eslintrc.yaml

@@ -2,6 +2,13 @@ env:
   es6: true
 
 rules:
+  comma-dangle: [error, {
+    arrays: always-multiline,
+    exports: only-multiline,
+    functions: only-multiline,
+    imports: only-multiline,
+    objects: only-multiline,
+  }]
   prefer-object-spread: error
   no-buffer-constructor: error
   no-mixed-operators:

tools/build-addons.mjs

@@ -31,7 +31,7 @@ async function buildAddon(dir) {
     await execFile(process.execPath, [nodeGyp, 'rebuild', `--directory=${dir}`],
                    {
                      stdio: 'inherit',
-                     env: { ...process.env, MAKEFLAGS: '-j1' }
+                     env: { ...process.env, MAKEFLAGS: '-j1' },
                    });
 
   // We buffer the output and print it out once the process is done in order

tools/doc/addon-verify.mjs

@@ -38,7 +38,7 @@ tree.children.forEach((node) => {
 
 await Promise.all(
   Object.keys(addons).flatMap(
-    (header) => verifyFiles(addons[header].files, header)
+    (header) => verifyFiles(addons[header].files, header),
   ));
 
 function verifyFiles(files, blockName) {
@@ -82,8 +82,8 @@ ${files[name].replace(
           sources: files.map(({ name }) => name),
           includes: ['../common.gypi'],
         },
-      ]
-    })
+      ],
+    }),
   });
 
   const dirCreation = mkdir(dir);

tools/doc/allhtml.mjs

@@ -96,8 +96,8 @@ all = all.slice(0, apiStart.index + apiStart[0].length)
       '\n</head>',
       buildCSSForFlavoredJS(new Set(Array.from(
         apicontent.matchAll(/(?<=<pre class="with-)\d+(?=-chars">)/g),
-        (x) => Number(x[0])
-      ))) + '\n</head>'
+        (x) => Number(x[0]),
+      ))) + '\n</head>',
     ) +
   apicontent +
   all.slice(apiEnd);

tools/doc/alljson.mjs

@@ -18,7 +18,7 @@ const results = {
   modules: [],
   classes: [],
   globals: [],
-  methods: []
+  methods: [],
 };
 
 // Identify files that should be skipped. As files are processed, they
@@ -33,7 +33,7 @@ for (const link of toc.match(/<a.*?>/g)) {
   if (!jsonFiles.includes(json) || seen.has(json)) continue;
   const data = JSON.parse(
     fs.readFileSync(new URL(`./${json}`, source), 'utf8')
-      .replace(/<a href=\\"#/g, `<a href=\\"${href}#`)
+      .replace(/<a href=\\"#/g, `<a href=\\"${href}#`),
   );
 
   for (const property in data) {

tools/doc/apilinks.mjs

@@ -27,7 +27,7 @@ function execSync(command) {
   try {
     return child_process.execSync(
       command,
-      { stdio: ['ignore', null, 'ignore'] }
+      { stdio: ['ignore', null, 'ignore'] },
     ).toString().trim();
   } catch {
     return '';

tools/doc/deprecationCodes.mjs

@@ -27,7 +27,7 @@ const testHeading = (headingNode, expectedDeprecationCode) => {
     assert.strictEqual(
       headingNode?.children[0]?.value.substring(0, 9),
       `${expectedDeprecationCode}: `,
-      'Ill-formed or out-of-order deprecation code.'
+      'Ill-formed or out-of-order deprecation code.',
     );
   } catch (e) {
     throw addMarkdownPathToErrorStack(e, headingNode);
@@ -39,7 +39,7 @@ const testYAMLComment = (commentNode) => {
     assert.match(
       commentNode?.value?.substring(0, 21),
       /^<!-- YAML\r?\nchanges:\r?\n/,
-      'Missing or ill-formed YAML comment.'
+      'Missing or ill-formed YAML comment.',
     );
   } catch (e) {
     throw addMarkdownPathToErrorStack(e, commentNode);
@@ -51,7 +51,7 @@ const testDeprecationType = (paragraphNode) => {
     assert.strictEqual(
       paragraphNode?.children[0]?.value?.substring(0, 6),
       'Type: ',
-      'Missing deprecation type.'
+      'Missing deprecation type.',
     );
   } catch (e) {
     throw addMarkdownPathToErrorStack(e, paragraphNode);
@@ -74,7 +74,7 @@ for (let i = 0; i < tree.children.length; i++) {
       assert.strictEqual(
         deprecationCodeAsText,
         expectedDeprecationCode,
-        'Deprecation codes are not ordered correctly.'
+        'Deprecation codes are not ordered correctly.',
       );
     } catch (e) {
       throw addMarkdownPathToErrorStack(e, node);