Skip to content

Commit 573171d

Browse files
kxxtRafaelGSS
authored andcommitted
deps: V8: cherry-pick 0ce2edb7adfd
Original commit message: Fix invalid template specialization Bug: chromium:40565911 Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420 Auto-Submit: Bruno Pitrus <[email protected]> Commit-Queue: Jakob Linke <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Reviewed-by: Jakob Linke <[email protected]> Cr-Commit-Position: refs/heads/main@{#99987} Refs: v8/v8@0ce2edb Fixes: #58485 PR-URL: #58773 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent d534706 commit 573171d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.19',
41+
'v8_embedder_string': '-node.17',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/codegen/riscv/macro-assembler-riscv.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -406,10 +406,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase {
406406
push_helper(rs...);
407407
}
408408

409-
template <>
410-
void push_helper(Register r) {
411-
StoreWord(r, MemOperand(sp, 0));
412-
}
409+
void push_helper() {}
413410

414411
public:
415412
// Push a number of registers. The leftmost register first (to the highest
@@ -554,10 +551,7 @@ class V8_EXPORT_PRIVATE MacroAssembler : public MacroAssemblerBase {
554551
LoadWord(r, MemOperand(sp, sizeof...(rs) * kSystemPointerSize));
555552
}
556553

557-
template <>
558-
void pop_helper(Register r) {
559-
LoadWord(r, MemOperand(sp, 0));
560-
}
554+
void pop_helper() {}
561555

562556
public:
563557
// Pop a number of registers. The leftmost register last (from the highest

0 commit comments

Comments
 (0)