http: don't emit 'readable' after 'close'

PR-URL: #32277
Refs: #28710
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: ronag

lib/_http_server.js

@@ -660,9 +660,12 @@ function clearIncoming(req) {
   if (parser && parser.incoming === req) {
     if (req.readableEnded) {
       parser.incoming = null;
+      req.emit('close');
     } else {
       req.on('end', clearIncoming);
     }
+  } else {
+    req.emit('close');
   }
 }
 
@@ -673,7 +676,6 @@ function resOnFinish(req, res, socket, state, server) {
   assert(state.incoming.length === 0 || state.incoming[0] === req);
 
   state.incoming.shift();
-  clearIncoming(req);
 
   // If the user never called req.read(), and didn't pipe() or
   // .resume() or .on('data'), then we call req._dump() so that the
@@ -682,7 +684,7 @@ function resOnFinish(req, res, socket, state, server) {
     req._dump();
 
   res.detachSocket(socket);
-  req.emit('close');
+  clearIncoming(req);
   process.nextTick(emitCloseNT, res);
 
   if (res._last) {

test/parallel/test-async-hooks-http-parser-destroy.js

@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const async_hooks = require('async_hooks');
 const http = require('http');
@@ -45,6 +45,9 @@ async_hooks.createHook({
 }).enable();
 
 const server = http.createServer((req, res) => {
+  req.on('close', common.mustCall(() => {
+    req.on('readable', common.mustNotCall());
+  }));
   res.end('Hello');
 });
 

test/parallel/test-http-no-read-no-dump.js

@@ -11,6 +11,10 @@ const server = http.createServer((req, res) => {
   res.writeHead(200);
   res.flushHeaders();
 
+  req.on('close', common.mustCall(() => {
+    req.on('end', common.mustNotCall());
+  }));
+
   req.connection.on('pause', () => {
     res.end();
     onPause();