test_runner: fix recursive run

PR-URL: #52322
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

Author: MoLow

lib/internal/test_runner/runner.js

@@ -563,6 +563,8 @@ function run(options) {
   root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
 
   if (process.env.NODE_TEST_CONTEXT !== undefined) {
+    process.emitWarning('node:test run() is being called recursively within a test file. skipping running files.');
+    root.postRun();
     return root.reporter;
   }
   let testFiles = files ?? createTestFileList();

test/fixtures/test-runner/recursive_run.js

@@ -0,0 +1,7 @@
+'use strict';
+
+const { test, run } = require('node:test');
+
+test('recursive run() calls', async () => {
+  for await (const event of run({ files: [__filename] }));
+});

test/parallel/test-runner-run.mjs

@@ -513,6 +513,18 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
     // eslint-disable-next-line no-unused-vars
     for await (const _ of stream);
   });
+
+  it('should avoid running recursively', async () => {
+    const stream = run({ files: [join(testFixtures, 'recursive_run.js')] });
+    let stderr = '';
+    stream.on('test:fail', common.mustNotCall());
+    stream.on('test:pass', common.mustCall(1));
+    stream.on('test:stderr', (c) => { stderr += c.message; });
+
+    // eslint-disable-next-line no-unused-vars
+    for await (const _ of stream);
+    assert.match(stderr, /Warning: node:test run\(\) is being called recursively/);
+  });
 });
 
 describe('forceExit', () => {