Skip to content

Commit 88fc6fa

Browse files
doowbbnoordhuis
authored andcommitted
Drop dependency on minimatch.
PR-URL: #1158 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 1e203c5 commit 88fc6fa

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/install.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ var fs = require('graceful-fs')
2525
, semver = require('semver')
2626
, fstream = require('fstream')
2727
, request = require('request')
28-
, minimatch = require('minimatch')
2928
, mkdir = require('mkdirp')
3029
, processRelease = require('./process-release')
3130
, win = process.platform == 'win32'
@@ -401,8 +400,8 @@ function install (fs, gyp, argv, callback) {
401400

402401
function valid (file) {
403402
// header files
404-
return minimatch(file, '*.h', { matchBase: true }) ||
405-
minimatch(file, '*.gypi', { matchBase: true })
403+
var extname = path.extname(file);
404+
return extname === '.h' || extname === '.gypi';
406405
}
407406

408407
/**

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"fstream": "^1.0.0",
2626
"glob": "^7.0.3",
2727
"graceful-fs": "^4.1.2",
28-
"minimatch": "^3.0.2",
2928
"mkdirp": "^0.5.0",
3029
"nopt": "2 || 3",
3130
"npmlog": "0 || 1 || 2 || 3 || 4",

0 commit comments

Comments
 (0)