Skip to content

Commit 0e8b7e5

Browse files
committed
feat: remove pump and raise minimum node to v10
1 parent 9478897 commit 0e8b7e5

16 files changed

+17
-18
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ fs.createReadStream('file/path/to/compress')
7575
.on('error', handleError);
7676

7777
// You should take care of stream errors in caution, use pump to handle error in one place
78-
const pump = require('pump');
78+
const { pipeline: pump } = require('stream');
7979
const sourceStream = fs.createReadStream('file/path/to/compress');
8080
const gzipStream = new compressing.gzip.FileStream();
8181
const destStream = fs.createWriteStream('path/to/destination.gz');

lib/tgz/file_stream.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const tar = require('../tar');
44
const gzip = require('../gzip');
55
const utils = require('../utils');
66
const stream = require('stream');
7-
const pump = require('pump');
7+
const { pipeline: pump } = require('stream');
88
const ready = require('get-ready');
99

1010
class TgzFileStream extends stream.Transform {

lib/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const fs = require('fs');
44
const path = require('path');
55
const mkdirp = require('mkdirp');
6-
const pump = require('pump');
6+
const { pipeline: pump } = require('stream');
77

88
// file/fileBuffer/stream
99
exports.sourceType = source => {

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,13 @@
3939
},
4040
"homepage": "https://github.com/node-modules/compressing#readme",
4141
"dependencies": {
42+
"@eggjs/yauzl": "^2.11.0",
4243
"flushwritable": "^1.0.0",
4344
"get-ready": "^1.0.0",
4445
"iconv-lite": "^0.5.0",
4546
"mkdirp": "^0.5.1",
46-
"pump": "^3.0.0",
4747
"streamifier": "^0.1.1",
4848
"tar-stream": "^1.5.2",
49-
"@eggjs/yauzl": "^2.11.0",
5049
"yazl": "^2.4.2"
5150
},
5251
"devDependencies": {
@@ -62,6 +61,6 @@
6261
"uuid": "^3.0.1"
6362
},
6463
"engines": {
65-
"node": ">= 4.0.0"
64+
"node": ">= 10.0.0"
6665
}
6766
}

test/gzip/file_stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ const fs = require('fs');
22
const os = require('os');
33
const path = require('path');
44
const uuid = require('uuid');
5-
const pump = require('pump');
5+
const { pipeline: pump } = require('stream');
66
const compressing = require('../..');
77
const assert = require('assert');
88

test/gzip/uncompress_stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const os = require('os');
44
const uuid = require('uuid');
55
const path = require('path');
66
const assert = require('assert');
7-
const pump = require('pump');
7+
const { pipeline: pump } = require('stream');
88
const streamifier = require('streamifier');
99
const compressing = require('../..');
1010

test/tar/file_stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const os = require('os');
66
const path = require('path');
77
const uuid = require('uuid');
88
const assert = require('assert');
9-
const pump = require('pump');
9+
const { pipeline: pump } = require('stream');
1010
const compressing = require('../..');
1111

1212
describe('test/tar/file_stream.test.js', () => {

test/tar/stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const fs = require('fs');
55
const os = require('os');
66
const path = require('path');
77
const uuid = require('uuid');
8-
const pump = require('pump');
8+
const { pipeline: pump } = require('stream');
99
const compressing = require('../..');
1010
const assert = require('assert');
1111
const TarStream = compressing.tar.Stream;

test/tar/uncompress_stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const path = require('path');
55
const uuid = require('uuid');
66
const assert = require('assert');
77
const mkdirp = require('mkdirp');
8-
const pump = require('pump');
8+
const { pipeline: pump } = require('stream');
99
const dircompare = require('dir-compare');
1010
const streamifier = require('streamifier');
1111
const { pipelinePromise } = require('../util');

test/tgz/file_stream.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const fs = require('fs');
44
const os = require('os');
55
const path = require('path');
66
const uuid = require('uuid');
7-
const pump = require('pump');
7+
const { pipeline: pump } = require('stream');
88
const compressing = require('../..');
99
const assert = require('assert');
1010

0 commit comments

Comments
 (0)