Skip to content

Commit d3c878e

Browse files
authored
Clean up some warnings (#1461)
1 parent 24706b2 commit d3c878e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/nimblepkg/packagemetadatafile.nim

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ proc loadMetaData*(dirName: string, raiseIfNotFound: bool, options: Options): Pa
6969
# Only show warning for installed packages (in pkgsDir) or Nim binaries dir
7070
# development packages don't need nimblemeta.json files
7171
if dirName.isSubdirOf(options.getPkgsDir()) and not dirName.isSubdirOf(options.nimBinariesDir):
72-
displayWarning(&"No {packageMetaDataFileName} file found in {dirName}")
72+
#dont show warning for global package install
73+
if findNimbleFile(dirName, error = false, options, warn = false) != "":
74+
displayWarning(&"No {packageMetaDataFileName} file found in {dirName}")
7375

7476
proc fillMetaData*(packageInfo: var PackageInfo, dirName: string,
7577
raiseIfNotFound: bool, options: Options) =

src/nimblepkg/vnext.nim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ proc getSolvedPkgFromInstalledPkgs*(satResult: SATResult, solvedPkg: SolvedPacka
289289
return none(PackageInfo)
290290

291291
proc thereIsNimbleFile*(options: Options): bool =
292-
return findNimbleFile(getCurrentDir(), error = false, options) != ""
292+
return findNimbleFile(getCurrentDir(), error = false, options, warn = false) != ""
293293

294294
proc solveLockFileDeps*(satResult: var SATResult, pkgList: seq[PackageInfo], options: Options) =
295295
let lockFile = options.lockFile(satResult.rootPackage.myPath.parentDir())

0 commit comments

Comments
 (0)