Skip to content

Commit a8a5c04

Browse files
committed
remove LocalizeMessageID until extract can extract it
1 parent 20fdd68 commit a8a5c04

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

v2/i18n/localizer.go

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,13 @@ func (l *Localizer) LocalizeMessage(msg *Message) (string, error) {
112112
})
113113
}
114114

115+
// TODO: uncomment this (and the test) when extract has been updated to extract these call sites too.
115116
// Localize returns a localized message.
116-
func (l *Localizer) LocalizeMessageID(messageID string) (string, error) {
117-
return l.Localize(&LocalizeConfig{
118-
MessageID: messageID,
119-
})
120-
}
117+
// func (l *Localizer) LocalizeMessageID(messageID string) (string, error) {
118+
// return l.Localize(&LocalizeConfig{
119+
// MessageID: messageID,
120+
// })
121+
// }
121122

122123
// LocalizeWithTag returns a localized message and the language tag.
123124
func (l *Localizer) LocalizeWithTag(lc *LocalizeConfig) (string, language.Tag, error) {
@@ -158,6 +159,15 @@ func (l *Localizer) LocalizeWithTag(lc *LocalizeConfig) (string, language.Tag, e
158159
return msg, tag, nil
159160
}
160161

162+
MessageID: messageID,
163+
PluralCount: kv["PluralCount"],
164+
TemplateData: args,
165+
}
166+
167+
return l.Localize(lc)
168+
}
169+
}
170+
161171
func (l *Localizer) getTemplate(id string, defaultMessage *Message) (language.Tag, *MessageTemplate) {
162172
// Fast path.
163173
// Optimistically assume this message id is defined in each language.

v2/i18n/localizer_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -567,9 +567,9 @@ func TestLocalizer_Localize(t *testing.T) {
567567
check(localizer.LocalizeMessage(test.conf.DefaultMessage))
568568
}
569569

570-
if test.conf.MessageID != "" && reflect.DeepEqual(test.conf, &LocalizeConfig{MessageID: test.conf.MessageID}) {
571-
check(localizer.LocalizeMessageID(test.conf.MessageID))
572-
}
570+
// if test.conf.MessageID != "" && reflect.DeepEqual(test.conf, &LocalizeConfig{MessageID: test.conf.MessageID}) {
571+
// check(localizer.LocalizeMessageID(test.conf.MessageID))
572+
// }
573573
})
574574
}
575575
}

0 commit comments

Comments
 (0)