Merge pull request #4262 from nextcloud/fix/activities-again

Some Activity fixes

Author: dartcafe

CHANGELOG.md

@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
 
 ## [unpublished]
 ### Fixed
+ - Fixed some activity bugs
  - Fixed nullish user settings
 
 ## [8.4.2] - 2025-08-31

lib/Filter/ActivityFilter.php

@@ -13,6 +13,7 @@
 use OCA\Polls\Event\OptionEvent;
 use OCA\Polls\Event\PollEvent;
 use OCA\Polls\Event\ShareEvent;
+use OCA\Polls\Event\VoteEvent;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 
@@ -49,6 +50,7 @@ class ActivityFilter implements \OCP\Activity\IFilter {
 		OptionEvent::UNCONFIRM,
 		OptionEvent::DELETE,
 		CommentEvent::DELETE,
+		VoteEvent::SET,
 	];
 
 	public function __construct(

lib/Model/UserBase.php

@@ -160,8 +160,6 @@ public function getIsGuest(): bool {
 	public function getSimpleType(): string {
 		if (in_array($this->type, [User::TYPE, Admin::TYPE])) {
 			return self::TYPE_USER;
-		} elseif ($this->type === Ghost::TYPE) {
-			return self::TYPE_GHOST;
 		}
 
 		return self::TYPE_GUEST;

src/stores/activity.ts

@@ -41,7 +41,7 @@ export const useActivityStore = defineStore('activity', {
 			return state.activities.filter(
 				(activity: Activity) =>
 					activity.object_type === 'poll'
-					&& activity.object_id - sessionStore.currentPollId === 0,
+					&& activity.object_id === Number(sessionStore.currentPollId),
 			)
 		},
 	},