Skip to content

Conversation

@bizob2828
Copy link
Member

Description

I noticed after #3247 that any subscribers listed after a disabled one weren't getting registered. It was because the inner for loop had to be properly exited. This PR fixes this and adds some basic tests to ensure it's working.

How to Test

node test/unit/shimmer.test.js

@jsumners-nr jsumners-nr force-pushed the fix-setup-subscribers branch from 315134c to 3aab2f8 Compare August 5, 2025 18:18
@amychisholm03 amychisholm03 merged commit e01fbaf into newrelic:next Aug 5, 2025
22 checks passed
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (c2defc4) to head (3aab2f8).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3275   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         364      364           
  Lines       52475    52476    +1     
  Branches       10       11    +1     
=======================================
+ Hits        51234    51236    +2     
+ Misses       1241     1240    -1     
Flag Coverage Δ
integration-tests-cjs-22.x 73.97% <66.66%> (+<0.01%) ⬆️
integration-tests-cjs-24.x 74.69% <66.66%> (?)
integration-tests-esm-20.x 49.97% <66.66%> (+<0.01%) ⬆️
integration-tests-esm-22.x 50.03% <66.66%> (+<0.01%) ⬆️
integration-tests-esm-24.x 51.70% <66.66%> (+<0.01%) ⬆️
unit-tests-20.x 88.26% <100.00%> (?)
unit-tests-22.x 88.27% <100.00%> (+0.01%) ⬆️
unit-tests-24.x 88.31% <100.00%> (?)
versioned-tests-20.x 80.46% <100.00%> (+<0.01%) ⬆️
versioned-tests-22.x 80.47% <100.00%> (-0.01%) ⬇️
versioned-tests-24.x ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Aug 5, 2025
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Aug 13, 2025
bizob2828 added a commit that referenced this pull request Aug 14, 2025
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Aug 14, 2025
bizob2828 added a commit to bizob2828/node-newrelic that referenced this pull request Aug 14, 2025
bizob2828 added a commit that referenced this pull request Aug 14, 2025
bizob2828 added a commit that referenced this pull request Aug 14, 2025
@bizob2828 bizob2828 deleted the fix-setup-subscribers branch August 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

2 participants