HARMONY-2035: Add validation of boolean parameters in Request.

Author: ygliuvt

harmony/request.py

@@ -426,7 +426,15 @@ def __init__(self,
         ]
         self.parameter_validations = [  # for simple, one-off validations
             (True if self.destination_url is None else self.destination_url.startswith('s3://'),
-             ('Destination URL must be an S3 location'))
+             'Destination URL must be an S3 location'),
+            (self.concatenate is None or isinstance(self.concatenate, bool),
+             'concatenate must be either True of False'),
+            (self.ignore_errors is None or isinstance(self.ignore_errors, bool),
+             'ignore_errors must be either True of False'),
+            (self.skip_preview is None or isinstance(self.skip_preview, bool),
+             'skip_preview must be either True of False'),
+            (self.pixel_subset is None or isinstance(self.pixel_subset, bool),
+             'pixel_subset must be either True of False')
         ]
 
     def _shape_error_messages(self, shape) -> List[str]:

tests/test_request.py

@@ -384,4 +384,10 @@ def test_request_with_pixel_subset_true():
 
 def test_request_defaults_to_pixel_subset_none():
     request = Request(collection=Collection('foobar'))
-    assert request.pixel_subset is None
+    assert request.pixel_subset is None
+
+def test_request_with_pixel_subset_invalid():
+    request = Request(collection=Collection('foobar'), pixel_subset='invalid')
+    messages = request.error_messages()
+    assert not request.is_valid()
+    assert 'pixel_subset must be either True of False' in messages