Skip to content

Commit 2f41946

Browse files
authored
Merge pull request #52 from stephenc-pace/fix/closing-streams
Prevent reusing stream ids
2 parents fcd1fac + 64e7fb0 commit 2f41946

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

nameko_grpc/connection.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,15 @@ def stream_ended(self, event):
214214
def stream_reset(self, event):
215215
"""Called when an incoming stream is reset.
216216
217-
Close any `ReceiveStream` that was opened for this stream.
217+
Close any Streams that we have opened for this stream_id
218218
"""
219219
log.debug("stream reset, stream %s", event.stream_id)
220220
receive_stream = self.receive_streams.pop(event.stream_id, None)
221221
if receive_stream:
222222
receive_stream.close()
223+
send_stream = self.send_streams.pop(event.stream_id, None)
224+
if send_stream:
225+
send_stream.close()
223226

224227
def settings_changed(self, event):
225228
log.debug("settings changed")

0 commit comments

Comments
 (0)