fix(editor): change the delete column endpoint to not take request body

Author: Cadiac

packages/@n8n/api-types/src/dto/data-store/delete-data-store-column.dto.ts

@@ -91,5 +91,4 @@ export {
 export { CreateDataStoreColumnDto } from './data-store/create-data-store-column.dto';
 export { AddDataStoreRowsDto } from './data-store/add-data-store-rows.dto';
 export { AddDataStoreColumnDto } from './data-store/add-data-store-column.dto';
-export { DeleteDataStoreColumnDto } from './data-store/delete-data-store-column.dto';
 export { MoveDataStoreColumnDto } from './data-store/move-data-store-column.dto';

packages/@n8n/api-types/src/dto/index.ts

@@ -484,9 +484,7 @@ describe('dataStore', () => {
 			});
 
 			// ACT
-			const result = await dataStoreService.deleteColumn(dataStoreId, {
-				columnId: c1.id,
-			});
+			const result = await dataStoreService.deleteColumn(dataStoreId, c1.id);
 
 			// ASSERT
 			expect(result).toEqual(true);
@@ -520,9 +518,7 @@ describe('dataStore', () => {
 			const { id: dataStoreId } = dataStore!;
 
 			// ACT
-			const result = dataStoreService.deleteColumn(dataStoreId, {
-				columnId: 'thisIsNotAnId',
-			});
+			const result = dataStoreService.deleteColumn(dataStoreId, 'thisIsNotAnId');
 
 			// ASSERT
 			await expect(result).rejects.toThrow(
@@ -542,9 +538,7 @@ describe('dataStore', () => {
 			});
 
 			// ACT
-			const result = dataStoreService.deleteColumn('this is not an id', {
-				columnId: c1.id,
-			});
+			const result = dataStoreService.deleteColumn('this is not an id', c1.id);
 
 			// ASSERT
 			await expect(result).rejects.toThrow(

packages/cli/src/modules/data-store/__tests__/data-store.service.test.ts

@@ -2,7 +2,6 @@ import {
 	AddDataStoreRowsDto,
 	AddDataStoreColumnDto,
 	CreateDataStoreDto,
-	DeleteDataStoreColumnDto,
 	ListDataStoreContentQueryDto,
 	ListDataStoreQueryDto,
 	MoveDataStoreColumnDto,
@@ -94,15 +93,15 @@ export class DataStoreController {
 		return await this.dataStoreService.addColumn(dataStoreId, dto);
 	}
 
-	@Delete('/:dataStoreId/columns')
+	@Delete('/:dataStoreId/columns/:columnId')
 	@ProjectScope('dataStore:update')
 	async deleteColumn(
 		_req: AuthenticatedRequest<{ projectId: string }>,
 		_res: Response,
 		@Param('dataStoreId') dataStoreId: string,
-		@Body dto: DeleteDataStoreColumnDto,
+		@Param('columnId') columnId: string,
 	) {
-		return await this.dataStoreService.deleteColumn(dataStoreId, dto);
+		return await this.dataStoreService.deleteColumn(dataStoreId, columnId);
 	}
 
 	@Patch('/:dataStoreId/columns/:columnId/move')

packages/cli/src/modules/data-store/data-store.controller.ts

@@ -1,7 +1,6 @@
 import type {
 	AddDataStoreColumnDto,
 	CreateDataStoreDto,
-	DeleteDataStoreColumnDto,
 	ListDataStoreContentQueryDto,
 	MoveDataStoreColumnDto,
 	DataStoreListOptions,
@@ -113,14 +112,14 @@ export class DataStoreService {
 		return true;
 	}
 
-	async deleteColumn(dataStoreId: string, dto: DeleteDataStoreColumnDto) {
+	async deleteColumn(dataStoreId: string, columnId: string) {
 		await this.validateDataStoreExists(
 			dataStoreId,
 			`Tried to delete column from non-existent data store '${dataStoreId}'`,
 		);
 
 		const existingColumnMatch = await this.dataStoreColumnRepository.findOneBy({
-			id: dto.columnId,
+			id: columnId,
 			dataStoreId,
 		});