Skip to content

Commit 429db00

Browse files
committed
Fix for test SecureSessionTest.testXdevapiTlsVersionsAndCiphersuites() failure with MySQL 8.1.0.
Change-Id: I030d752e545e5b99c5b602083f6e6d256c469c6a
1 parent d52033a commit 429db00

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/test/java/testsuite/x/devapi/SecureSessionTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -952,10 +952,12 @@ public void testXdevapiTlsVersionsAndCiphersuites() throws Exception {
952952
String testCipher = "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256"; // IANA Cipher name
953953
String expectedCipher = "ECDHE-RSA-AES128-GCM-SHA256"; // OpenSSL Cipher name
954954
String testTlsVersion = "TLSv1.2";
955+
String testCipher2 = "DHE-RSA-AES128-GCM-SHA256";
955956
if (mysqlVersionMeetsMinimum(ServerVersion.parseVersion("8.2.0"))) {
956957
testCipher = "TLS_AES_256_GCM_SHA384"; // IANA Cipher name
957958
expectedCipher = "TLS_AES_256_GCM_SHA384"; // IANA Cipher name
958959
testTlsVersion = "TLSv1.3";
960+
testCipher2 = "TLS_AES_128_GCM_SHA256";
959961
}
960962

961963
// newer GPL servers, like 8.0.4+, are using OpenSSL and can use RSA encryption, while old ones compiled with yaSSL cannot
@@ -1088,7 +1090,7 @@ public void testXdevapiTlsVersionsAndCiphersuites() throws Exception {
10881090
// cipher-suites.
10891091
// Assess that the connection property is initialized with the correct values and that the correct protocol was used (consult status variable
10901092
// ssl_cipher for details).
1091-
testSession = this.fact.getSession(this.sslFreeBaseUrl + makeParam(PropertyKey.xdevapiTlsCiphersuites, testCipher + ",TLS_AES_128_GCM_SHA256"));
1093+
testSession = this.fact.getSession(this.sslFreeBaseUrl + makeParam(PropertyKey.xdevapiTlsCiphersuites, testCipher + "," + testCipher2));
10921094
assertSessionStatusEquals(testSession, "mysqlx_ssl_cipher", expectedCipher);
10931095
assertTlsVersion(testSession, testTlsVersion);
10941096
testSession.close();
@@ -1128,7 +1130,7 @@ public void testXdevapiTlsVersionsAndCiphersuites() throws Exception {
11281130
// cipher-suites.
11291131
// Assess that the connection property is initialized with the correct values and that the correct protocol was used (consult status variable
11301132
// ssl_cipher for details).
1131-
props.setProperty(PropertyKey.xdevapiTlsCiphersuites.getKeyName(), testCipher + ",TLS_AES_128_GCM_SHA256");
1133+
props.setProperty(PropertyKey.xdevapiTlsCiphersuites.getKeyName(), testCipher + "," + testCipher2);
11321134
testSession = this.fact.getSession(props);
11331135
assertSessionStatusEquals(testSession, "mysqlx_ssl_cipher", expectedCipher);
11341136
testSession.close();
@@ -1159,7 +1161,7 @@ public void testXdevapiTlsVersionsAndCiphersuites() throws Exception {
11591161
assertTlsVersion(testSession, testTlsVersion);
11601162
testSession.close();
11611163

1162-
cli = cf.getClient(this.sslFreeBaseUrl + makeParam(PropertyKey.xdevapiTlsCiphersuites, testCipher + ",TLS_AES_128_GCM_SHA256"),
1164+
cli = cf.getClient(this.sslFreeBaseUrl + makeParam(PropertyKey.xdevapiTlsCiphersuites, testCipher + "," + testCipher2),
11631165
"{\"pooling\": {\"enabled\": true}}");
11641166
testSession = cli.getSession();
11651167
assertSessionStatusEquals(testSession, "mysqlx_ssl_cipher", expectedCipher);

0 commit comments

Comments
 (0)