[Confirm] Support returning defect photos when they are fetched.

Author: neprune

perllib/Integrations/Confirm.pm

@@ -181,6 +181,18 @@ has defect_update_job_photo_statuses => (
 );
 
 
+=head2 include_photos_on_defect_fetch
+
+Whether or not to include defect photos when they are fetched in get_service_requests.
+
+=cut
+
+has include_photos_on_defect_fetch => (
+    is => 'lazy',
+    default => sub { $_[0]->config->{include_photos_on_defect_fetch} }
+);
+
+
 =head2 external_system_number
 
 A code to use to mark enquiries we submit as coming from us; with this set,
@@ -611,6 +623,7 @@ sub defects_graphql_query { # XXX factor together with jobs?
     }
     documents {
       url
+      documentName
     }
     description
   }

perllib/Open311/Endpoint/Integration/Confirm.pm

@@ -1440,6 +1440,14 @@ sub _get_service_requests_for_defects {
 
         my $description = $self->_description_for_defect($defect, $service);
 
+        my @media_urls;
+        if ($integ->include_photos_on_defect_fetch) {
+            my @defect_docs = $self->_parse_graphql_docs($defect->{documents});
+            my @filtered = $self->filter_photos_graphql(@defect_docs);
+            my @urls = map { $self->construct_photo_url_from_graphql_fetched_doc($_) } @filtered;
+            push @media_urls, @urls;
+        }
+
         my %args = (
             service => $service,
             service_request_id => 'DEFECT_' . $defect_id,
@@ -1450,6 +1458,7 @@ sub _get_service_requests_for_defects {
             # enquiries above
             latlong => [ $defect->{northing}, $defect->{easting} ],
             status => $status,
+            @media_urls ? ( media_url => \@media_urls ) : (),
         );
 
         my $request = $self->new_request( %args );

t/open311/endpoint/confirm_photos.t

@@ -224,4 +224,57 @@ subtest "fetching of job photos for defect update via GraphQL" => sub {
     $integration->unmock('perform_request_graphql');
 };
 
+
+subtest "fetching of defect photos for defect fetch" => sub {
+    $integration->mock(perform_request_graphql => sub {
+        my ( $self, %args ) = @_;
+
+        $args{type} ||= '';
+        $args{query} ||= '';
+
+        if ( $args{type} eq 'defects' ) {
+            return {
+                data => {
+                    defects => [
+                        {
+                            defectNumber => 1,
+                            easting => 1,
+                            northing => 1,
+                            loggedDate => '2025-01-01T00:00:00Z',
+                            targetDate => '2025-01-01T00:00:00Z',
+                            defectType => {
+                                code => "SLDA",
+                            },
+                            documents => [
+                                {
+                                    url => "/ConfirmWeb/api/tenant/attachments/DEFECT/123/1",
+                                    documentName => "photo.jpg"
+                                }
+                            ],
+                        }
+                    ]
+                }
+            };
+        } elsif ( $args{type} eq 'defect_types' ) {
+            return {
+                data => {
+                    defectTypes => [
+                        { code => 'SLDA', name => 'Defective Street Light' },
+                    ],
+                },
+            };
+        }
+        return {};
+    });
+
+    my $res = $endpoint_graphql->run_test_request(
+        GET => '/requests.xml?start_date=2025-01-01T00:00:00Z&end_date=2025-01-01T01:00:00Z',
+    );
+    ok $res->is_success, 'valid request' or diag $res->content;
+    contains_string $res->content, '<media_url>http://example.com/photos?jurisdiction_id=confirm_dummy_photos_graphql&amp;doc_url=%2Fattachments%2FDEFECT%2F123%2F1</media_url>';
+
+    $lwp->mock(request => \&empty_json);
+    $integration->unmock('perform_request_graphql');
+};
+
 done_testing;

t/open311/endpoint/confirm_photos_graphql.yml

@@ -24,3 +24,5 @@ defect_service_mapping:
   SLDA:
     group: Street Lighting
     category: Defective Street Light
+
+include_photos_on_defect_fetch: true