Skip to content

[material-ui][useMediaQuery] Adapt test implementation for React 19 #43269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[material-ui][useMediaQuery] Adapt test implementation for React 19 #43269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 39 additions & 29 deletions packages/mui-material/src/useMediaQuery/useMediaQuery.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,34 +14,44 @@ import useMediaQuery from '@mui/material/useMediaQuery';
import { ThemeProvider } from '@mui/material/styles';

const usesUseSyncExternalStore = React.useSyncExternalStore !== undefined;
const matchMediaInstances = new Map();

function createMatchMedia(width, ref) {
function createMatchMedia(width) {
const listeners = [];
return (query) => {
const instance = {
matches: mediaQuery.match(query, {
width,
}),
addEventListener: (eventType, listener) => {
listeners.push(listener);
},
removeEventListener: (eventType, listener) => {
const index = listeners.indexOf(listener);
if (index > -1) {
listeners.splice(index, 1);
}
},
};
ref.push({
instance,
listeners,
});
let instance = matchMediaInstances.get(query)?.instance;

if (!instance) {
instance = {
matches: mediaQuery.match(query, {
width,
}),
addEventListener: (eventType, listener) => {
listeners.push(listener);
},
removeEventListener: (eventType, listener) => {
const index = listeners.indexOf(listener);
if (index > -1) {
listeners.splice(index, 1);
}
},
};
matchMediaInstances.set(query, {
instance,
listeners,
});
}

return instance;
};
}

describe('useMediaQuery', () => {
const { render, renderToString } = createRenderer();
const { render, renderToString } = createRenderer({ strict: true });

beforeEach(() => {
matchMediaInstances.clear();
});

describe('without window.matchMedia', () => {
let originalMatchmedia;
Expand All @@ -68,11 +78,8 @@ describe('useMediaQuery', () => {
});

describe('with window.matchMedia', () => {
let matchMediaInstances;

beforeEach(() => {
matchMediaInstances = [];
const fakeMatchMedia = createMatchMedia(1200, matchMediaInstances);
const fakeMatchMedia = createMatchMedia(1200);
// can't stub nonexistent properties with sinon
// jsdom does not implement window.matchMedia
if (window.matchMedia === undefined) {
Expand Down Expand Up @@ -276,8 +283,9 @@ describe('useMediaQuery', () => {
expect(getRenderCountRef.current()).to.equal(usesUseSyncExternalStore ? 2 : 4);
});

it('should observe the media query', () => {
it('should observe the media query', async () => {
const getRenderCountRef = React.createRef();
const query = '(min-width:2000px)';
function Test(props) {
const matches = useMediaQuery(props.query);

Expand All @@ -291,14 +299,16 @@ describe('useMediaQuery', () => {
query: PropTypes.string.isRequired,
};

render(<Test query="(min-width:2000px)" />);
render(<Test query={query} />);

expect(getRenderCountRef.current()).to.equal(1);
expect(screen.getByTestId('matches').textContent).to.equal('false');

act(() => {
matchMediaInstances[matchMediaInstances.length - 1].instance.matches = true;
matchMediaInstances[matchMediaInstances.length - 1].listeners[0]();
await act(async () => {
matchMediaInstances.get(query).instance.matches = true;
matchMediaInstances.get(query).listeners[0]();
});

expect(screen.getByTestId('matches').textContent).to.equal('true');
expect(getRenderCountRef.current()).to.equal(2);
});
Expand Down