one step further

Author: oliviertassinari

docs/data/material/getting-started/templates/shared-theme/AppTheme.js

@@ -34,7 +34,7 @@ function AppTheme({ children, disableCustomTheme, themeComponents }) {
         });
   }, [disableCustomTheme, themeComponents]);
   if (disableCustomTheme) {
-    return <React.Fragment>{children}</React.Fragment>;
+    return children;
   }
   return (
     <ThemeProvider theme={theme} disableTransitionOnChange>

docs/data/material/getting-started/templates/shared-theme/AppTheme.tsx

@@ -46,7 +46,7 @@ export default function AppTheme({
         });
   }, [disableCustomTheme, themeComponents]);
   if (disableCustomTheme) {
-    return <React.Fragment>{children}</React.Fragment>;
+    return children;
   }
   return (
     <ThemeProvider theme={theme} disableTransitionOnChange>

packages/api-docs-builder/ApiBuilders/ComponentApiBuilder.ts

@@ -635,43 +635,49 @@ export default async function generateComponentApi(
   } catch (error) {
     // fallback to default logic if there is no `create*` definition.
     if ((error as Error).message === 'No suitable component definition found.') {
-      reactApi = docgenParse(src, (ast) => {
-        let node;
-        // TODO migrate to react-docgen v6, using Babel AST now
-        astTypes.visit(ast, {
-          visitFunctionDeclaration: (path) => {
-            if (path.node.params[0].name === 'props') {
-              node = path;
-            }
-            return false;
-          },
-          visitVariableDeclaration: (path) => {
-            const definitions: any[] = [];
-            if (path.node.declarations) {
-              path
-                .get('declarations')
-                .each((declarator: any) => definitions.push(declarator.get('init')));
-            }
-            definitions.forEach((definition) => {
-              // definition.value.expression is defined when the source is in TypeScript.
-              const expression = definition.value?.expression
-                ? definition.get('expression')
-                : definition;
-              if (expression.value?.callee) {
-                const definitionName = expression.value.callee.name;
-                if (definitionName === `create${componentInfo.name}`) {
-                  node = expression;
-                }
+      reactApi = docgenParse(
+        src,
+        (ast) => {
+          let node;
+          // TODO migrate to react-docgen v6, using Babel AST now
+          astTypes.visit(ast, {
+            visitFunctionDeclaration: (functionPath) => {
+              // @ts-ignore
+              if (functionPath.node.params[0].name === 'props') {
+                node = functionPath;
               }
-            });
-            return false;
-          },
-        });
+              return false;
+            },
+            visitVariableDeclaration: (variablePath) => {
+              const definitions: any[] = [];
+              if (variablePath.node.declarations) {
+                variablePath
+                  .get('declarations')
+                  .each((declarator: any) => definitions.push(declarator.get('init')));
+              }
+              definitions.forEach((definition) => {
+                // definition.value.expression is defined when the source is in TypeScript.
+                const expression = definition.value?.expression
+                  ? definition.get('expression')
+                  : definition;
+                if (expression.value?.callee) {
+                  const definitionName = expression.value.callee.name;
+                  if (definitionName === `create${componentInfo.name}`) {
+                    node = expression;
+                  }
+                }
+              });
+              return false;
+            },
+          });
 
-        return node;
-      }, defaultHandlers, {
-        filename,
-      });
+          return node;
+        },
+        defaultHandlers,
+        {
+          filename,
+        },
+      );
     } else {
       throw error;
     }

packages/mui-base/src/ClickAwayListener/ClickAwayListener.tsx

@@ -209,7 +209,7 @@ function ClickAwayListener(props: ClickAwayListenerProps): React.JSX.Element {
     return undefined;
   }, [handleClickAway, mouseEvent]);
 
-  return <React.Fragment>{React.cloneElement(children, childrenProps)}</React.Fragment>;
+  return React.cloneElement(children, childrenProps);
 }
 
 ClickAwayListener.propTypes /* remove-proptypes */ = {

packages/mui-base/src/NoSsr/NoSsr.tsx

@@ -38,8 +38,8 @@ function NoSsr(props: NoSsrProps): React.JSX.Element {
     }
   }, [defer]);
 
-  // We need the Fragment here to force react-docgen to recognise NoSsr as a component.
-  return <React.Fragment>{mountedState ? children : fallback}</React.Fragment>;
+  // TODO casting won't be needed at one point https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65135
+  return (mountedState ? children : fallback) as React.JSX.Element;
 }
 
 NoSsr.propTypes /* remove-proptypes */ = {

packages/mui-base/src/Portal/Portal.tsx

@@ -64,14 +64,10 @@ const Portal = React.forwardRef(function Portal(
       };
       return React.cloneElement(children, newProps);
     }
-    return <React.Fragment>{children}</React.Fragment>;
+    return children;
   }
 
-  return (
-    <React.Fragment>
-      {mountNode ? ReactDOM.createPortal(children, mountNode) : mountNode}
-    </React.Fragment>
-  );
+  return mountNode ? ReactDOM.createPortal(children, mountNode) : mountNode;
 }) as React.ForwardRefExoticComponent<PortalProps & React.RefAttributes<Element>>;
 
 Portal.propTypes /* remove-proptypes */ = {

packages/mui-material/src/Hidden/HiddenJs.js

@@ -50,7 +50,7 @@ function HiddenJs(props) {
     return null;
   }
 
-  return <React.Fragment>{children}</React.Fragment>;
+  return children;
 }
 
 HiddenJs.propTypes = {

packages/mui-material/src/NoSsr/NoSsr.tsx

@@ -38,7 +38,8 @@ function NoSsr(props: NoSsrProps): React.JSX.Element {
     }
   }, [defer]);
 
-  return <React.Fragment>{mountedState ? children : fallback}</React.Fragment>;
+  // TODO casting won't be needed at one point https://github.com/DefinitelyTyped/DefinitelyTyped/pull/65135
+  return (mountedState ? children : fallback) as React.JSX.Element;
 }
 
 NoSsr.propTypes /* remove-proptypes */ = {

packages/mui-material/src/Portal/Portal.tsx

@@ -64,14 +64,10 @@ const Portal = React.forwardRef(function Portal(
       };
       return React.cloneElement(children, newProps);
     }
-    return <React.Fragment>{children}</React.Fragment>;
+    return children;
   }
 
-  return (
-    <React.Fragment>
-      {mountNode ? ReactDOM.createPortal(children, mountNode) : mountNode}
-    </React.Fragment>
-  );
+  return mountNode ? ReactDOM.createPortal(children, mountNode) : mountNode;
 }) as React.ForwardRefExoticComponent<PortalProps & React.RefAttributes<Element>>;
 
 Portal.propTypes /* remove-proptypes */ = {