TSL: Align API of blur filters. #31557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
reviewed
Aug 3, 2025
| textureNode = convertToTexture( textureNode ); | ||
| bluramount = nodeObject( bluramount ); | ||
| const repeats = nodeObject( options.size ) || float( 45 ); | ||
| const mask = options.mask || null; |
There was a problem hiding this comment.
Apparently, mask also needs to be compatible with .sample() interface, I think we can use convertToTexture() too.
There was a problem hiding this comment.
It would also be interesting to deprecate premultipliedGaussianBlur() in favor of options to align API.
There was a problem hiding this comment.
Apparently, mask also needs to be compatible with .sample() interface, I think we can use convertToTexture() too.
Like so?
const mask = ( options.mask !== null ) ? convertToTexture( options.mask ) : null;There was a problem hiding this comment.
Yess! I started a PR right after commenting. #31559
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31556 (comment)
Description
Implements the feedback from #31556 (comment).