GridHelper: give different colors to X-centerLine and Z-centerLine

[robyanne92]

With this modification I added a third parameter to the GridHelper construction, giving the possibility to set different colors to X-centerLine and Z-centerLine, like in Blender 2.80. This could be useful to mark the X-centerLine with the color of x-axis and the Z-centerLine with the color of z-axis.

[Mugen87]

Unfortunately, the parameter order is now confusing. It should be at least: colorXCenterLine, colorZCenterLine, colorGrid. Or even better: colorGrid, colorXCenterLine, colorZCenterLine. However, this will break backwards compatibility.

[robyanne92]

Unfortunately, the parameter order is now confusing. It should be at least: colorXCenterLine, colorZCenterLine, colorGrid. Or even better: colorGrid, colorXCenterLine, colorZCenterLine. However, this will break backwards compatibility.

I had noticed it too. Let me know if you need help with any code changes.

[WestLangley]

I think this would be a useful new feature.

We can change the API in such a way the args can be checked and backwards-compatibility can be maintained.

var options = { color: 0xffffff, colorXAxis: 0xff0000, colorZAxis: 0x0000ff );
new THREE.GridHelper( size, divisions, options );

Or, we can just add a method to reset the z-axis color:

gridHelper.setZAxisColor( color );

Or, since it is just a helper, we can change order of the arguments and update the migration guide:

new THREE.GridHelper( size, divisions, color, colorXAxis,  colorZAxis );

My preference is the last option.

@mrdoob will have to make this decision.

[Mugen87]

Or, since it is just a helper, we can change order of the arguments and update the migration guide:

Then we have to adjust many examples (approx. 25) since instances of GridHelper are often created with both color values. This is probably also true for a lot of user level code.

[WestLangley]

Then we have to adjust many examples

That will take 10 minutes.

This is probably also true for a lot of user level code.

Who knows, but it is not going to kill them.

I think for this Helper we can change the order of the arguments for clarity and support the suggested feature.

[WestLangley]

/ping @mrdoob Can you please state your preference? Do you want the feature? Which API?

[Mugen87]

Considering #21431 (comment), this PR can be closed.