Unify setting postprocessing pass size #17037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size is now set the same way in EffectComposer.addPass() and EffectComposer.setSize().
Mugen87
approved these changes
Jul 16, 2019
Owner
|
Thanks! |
Collaborator
|
Be careful, everybody! This PR should have been applied to the JS file. |
Contributor
Author
|
Sorry, I should have checked my assumptions about how to contribute changes to the modularized code. I now realize that files in both js/ and jsm/ should be changed in patches like this. There's a new PR that fixes the file in js/ : #17043 |
Collaborator
|
We really need to get #16920 in place^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size is now set the same way in EffectComposer.addPass() and EffectComposer.setSize().