Skip to content

HDRCubeTextureLoader: add setType() method #16718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

HDRCubeTextureLoader: add setType() method #16718

merged 1 commit into from
Jun 7, 2019

Conversation

@WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Jun 7, 2019

With this change, the signature of of the load() method now is consistent with that of the other texture loaders.

new THREE.HDRCubeTextureLoader()
	.setType( THREE.UnsignedByteType )
	.load( hdrUrls, function ( hdrCubeMap ) { ...

Also, HDRCubeTextureLoader now leverages the decoding capabilities of RGBELoader. UnsignedByteType, FloatType, and HalfFloatType are supported.

The examples are updated to accommodate the API change.

@mrdoob mrdoob added this to the r106 milestone Jun 7, 2019
@mrdoob mrdoob merged commit 09f6cd1 into mrdoob:dev Jun 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 7, 2019

Thanks!

@Mugen87 Mugen87 mentioned this pull request Jun 7, 2019
Merged
@WestLangley WestLangley deleted the dev_hdrcubetexture_loader branch June 7, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

2 participants

@WestLangley @mrdoob