Skip to content

Prevent unexpected renderTarget override in OutlineEffect #16354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2019
Merged

Prevent unexpected renderTarget override in OutlineEffect #16354

merged 1 commit into from
May 2, 2019

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Apr 29, 2019 •
edited
Loading

I realized I shouldn't call setRenderTarget() with null in OutlineEffect unless deprecated renderTarget argument is passed. Otherwise it unexpectedly overrides renderTarget set to renderer beforehand.

@mrdoob mrdoob added this to the r105 milestone May 2, 2019
@mrdoob mrdoob merged commit b524f4b into mrdoob:dev May 2, 2019
@mrdoob
Copy link
Owner

mrdoob commented May 2, 2019

Thanks!

@takahirox takahirox deleted the FixOutlineEffectRenderTarget branch May 2, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r105

Development

Successfully merging this pull request may close these issues.

2 participants

@takahirox @mrdoob