NodeMaterial - fix name conflict + label + gets and sets #15675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#15666
New examples
label
https://rawgit.com/sunag/three.js/dev-fix-nameconflict/examples/webgl_materials_nodes.html?e=label
Description
Conflicting names for varying and temp varissue NodeMaterial: Conflicting names for varying and temp var. #15666setLabelandgetLabelinTempNodenodeU0= node uniform idnodeV0= node varying idnodeT0= node temp idisShared,isUnique,isReadonlyrenamed togetShared,getUnique,getReadonlyUsages
label
optimization alerts
https://github.com/sunag/three.js/blob/40651f3fa6e6b12a2ae145cf3de14efde04065d3/examples/webgl_materials_nodes.html#L2543
https://github.com/sunag/three.js/blob/40651f3fa6e6b12a2ae145cf3de14efde04065d3/examples/webgl_materials_nodes.html#L2560
readonly