fix LogLuvToLinear convert error #15627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jan 22, 2019
Collaborator
|
@Mugen87 Did you test this? Can you share your testbed? |
Owner
|
The explanation in #15621 is convincing. But I agree with @WestLangley, could you share your tests or screenshots? |
Owner
|
/cc @bhouston |
Contributor
|
This bug was my fault. I did test converting to and back between the various functions but given that the bug was in both functions, I didn't catch this bug. Sorry about that. And thank you @AngusLang |
Owner
|
Thanks! |
Owner
|
I guess we should fix the code in this file too: https://github.com/mrdoob/three.js/blob/dev/examples/js/nodes/utils/ColorSpaceNode.js |
mrdoob
added a commit
that referenced
this pull request
Jan 25, 2019
Owner
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15621