Skip to content

Commit f43719d

Browse files
authored
Merge pull request #20340 from ycw/patch-4
set AmbientLight.castshadow to `false`
2 parents 4c75646 + 3454f86 commit f43719d

File tree

6 files changed

+0
-24
lines changed

6 files changed

+0
-24
lines changed

docs/api/en/lights/AmbientLight.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ <h2>Properties</h2>
4646
See the base [page:Light Light] class for common properties.
4747
</p>
4848

49-
<h3>[property:Boolean castShadow]</h3>
50-
<p>
51-
This is set to *undefined* in the constructor as ambient lights cannot cast shadows.
52-
</p>
53-
5449

5550
<h2>Methods</h2>
5651
<p>

docs/api/en/lights/HemisphereLight.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ <h2>Properties</h2>
5252
See the base [page:Light Light] class for common properties.
5353
</p>
5454

55-
<h3>[property:Boolean castShadow]</h3>
56-
<p>
57-
This is set to *undefined* in the constructor as hemisphere lights cannot cast shadows.
58-
</p>
59-
60-
6155
<h3>[property:Float color]</h3>
6256
<p>
6357
The light's sky color, as passed in the constructor.

src/lights/AmbientLight.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ export class AmbientLight extends Light {
2020
*/
2121
type: string;
2222

23-
/**
24-
* @default undefined
25-
*/
26-
castShadow: boolean;
2723
readonly isAmbientLight: true;
2824

2925
}

src/lights/AmbientLight.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ function AmbientLight( color, intensity ) {
66

77
this.type = 'AmbientLight';
88

9-
this.castShadow = undefined;
10-
119
}
1210

1311
AmbientLight.prototype = Object.assign( Object.create( Light.prototype ), {

src/lights/HemisphereLight.d.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ export class HemisphereLight extends Light {
2525
*/
2626
position: Vector3;
2727

28-
/**
29-
* @default undefined
30-
*/
31-
castShadow: boolean;
32-
3328
groundColor: Color;
3429

3530
readonly isHemisphereLight: true;

src/lights/HemisphereLight.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ function HemisphereLight( skyColor, groundColor, intensity ) {
88

99
this.type = 'HemisphereLight';
1010

11-
this.castShadow = undefined;
12-
1311
this.position.copy( Object3D.DefaultUp );
1412
this.updateMatrix();
1513

0 commit comments

Comments
 (0)