Skip to content

Commit efd712a

Browse files
authored
Merge pull request #14715 from WestLangley/dev-cleanup_lookat
Examples: Avoid new when calling lookAt()
2 parents eb5d999 + 80b7da2 commit efd712a

17 files changed

+17
-17
lines changed

docs/manual/introduction/Drawing-lines.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ <h1>[name]</h1>
2323

2424
var camera = new THREE.PerspectiveCamera( 45, window.innerWidth / window.innerHeight, 1, 500 );
2525
camera.position.set( 0, 0, 100 );
26-
camera.lookAt( new THREE.Vector3( 0, 0, 0 ) );
26+
camera.lookAt( 0, 0, 0 );
2727

2828
var scene = new THREE.Scene();
2929
</code>

examples/canvas_interactive_voxelpainter.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
camera = new THREE.PerspectiveCamera( 40, window.innerWidth / window.innerHeight, 1, 10000 );
5353
camera.position.set( 500, 800, 1300 );
54-
camera.lookAt( new THREE.Vector3() );
54+
camera.lookAt( 0, 0, 0 );
5555

5656
scene = new THREE.Scene();
5757
scene.background = new THREE.Color( 0xf0f0f0 );

examples/css3d_sprites.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959

6060
camera = new THREE.PerspectiveCamera( 75, window.innerWidth / window.innerHeight, 1, 5000 );
6161
camera.position.set( 600, 400, 1500 );
62-
camera.lookAt( new THREE.Vector3() );
62+
camera.lookAt( 0, 0, 0 );
6363

6464
scene = new THREE.Scene();
6565

examples/misc_animation_authoring.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353

5454
camera = new THREE.PerspectiveCamera( 70, window.innerWidth / window.innerHeight, 1, 3000 );
5555
camera.position.set( 1000, 500, 1000 );
56-
camera.lookAt( new THREE.Vector3( 0, 200, 0 ) );
56+
camera.lookAt( 0, 200, 0 );
5757

5858
scene = new THREE.Scene();
5959
scene.add( new THREE.GridHelper( 1000, 10 ) );

examples/misc_controls_transform.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
camera = new THREE.PerspectiveCamera( 70, window.innerWidth / window.innerHeight, 1, 3000 );
5353
camera.position.set( 1000, 500, 1000 );
54-
camera.lookAt( new THREE.Vector3( 0, 200, 0 ) );
54+
camera.lookAt( 0, 200, 0 );
5555

5656
scene = new THREE.Scene();
5757
scene.add( new THREE.GridHelper( 1000, 10 ) );

examples/webgl_camera_array.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
subcamera.position.y = 0.5 - ( y / AMOUNT );
4343
subcamera.position.z = 1.5;
4444
subcamera.position.multiplyScalar( 2 );
45-
subcamera.lookAt( new THREE.Vector3() );
45+
subcamera.lookAt( 0, 0, 0 );
4646
subcamera.updateMatrixWorld();
4747
cameras.push( subcamera );
4848

examples/webgl_interactive_voxelpainter.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959

6060
camera = new THREE.PerspectiveCamera( 45, window.innerWidth / window.innerHeight, 1, 10000 );
6161
camera.position.set( 500, 800, 1300 );
62-
camera.lookAt( new THREE.Vector3() );
62+
camera.lookAt( 0, 0, 0 );
6363

6464
scene = new THREE.Scene();
6565
scene.background = new THREE.Color( 0xf0f0f0 );

examples/webgl_lights_pointlights2.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767

6868
camera = new THREE.PerspectiveCamera( 50, window.innerWidth / window.innerHeight, 1, 300 );
6969
camera.position.set( 0, 15, 150 );
70-
camera.lookAt( new THREE.Vector3() );
70+
camera.lookAt( 0, 0, 0 );
7171

7272
// SCENE
7373

examples/webgl_loader_assimp.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
camera = new THREE.PerspectiveCamera( 25, window.innerWidth / window.innerHeight, 1, 10000 );
7171
camera.position.set( 600, 1150, 5 );
7272
camera.up.set( 0, 0, 1 );
73-
camera.lookAt( new THREE.Vector3( -100, 0, 0 ) );
73+
camera.lookAt( - 100, 0, 0 );
7474

7575
scene = new THREE.Scene();
7676

examples/webgl_loader_collada.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858

5959
camera = new THREE.PerspectiveCamera( 45, window.innerWidth / window.innerHeight, 0.1, 2000 );
6060
camera.position.set( 8, 10, 8 );
61-
camera.lookAt( new THREE.Vector3( 0, 3, 0 ) );
61+
camera.lookAt( 0, 3, 0 );
6262

6363
scene = new THREE.Scene();
6464

0 commit comments

Comments
 (0)